Improve how directories are specfied in Jenkinsfile #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that directories that are specific to our internal details can easily be converted to environment variables.
Two benefits: they are run in parallel and we don't have to lock the test database for more than necessary.
arteymix
commented
Nov 27, 2023
| steps { | ||
| slackSend color: 'good', channel: '#gemma', message: "Gemma ${gemmaVersion} has been released! It will be deployed shortly..." | ||
| } | ||
| } |
There was a problem hiding this comment.
This belong in a different PR.
arteymix
commented
Nov 27, 2023
| slackSend color: 'good', message: "Gemma ${gemmaVersion} has been deployed! Enjoy it while it's still warm!" | ||
| } | ||
| } | ||
| } |
arteymix
force-pushed
the
development
branch
2 times, most recently
from
84692c7
to
e0ec3da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leaking details about our internal folder structure is unnecessary. We can store all that in the Jenkins configuration as environment varaibles.
TODO