Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next #83

Merged
merged 41 commits into from
Sep 5, 2019
Merged

Next #83

merged 41 commits into from
Sep 5, 2019

Conversation

evadelmas
Copy link
Collaborator

Fixes #76 #77 and #70

Summary of changes:

  1. Improved behavior for extinctions
  2. Scaling for biological rates (controlled by model_parameters keywords scale_metabolism scale_growth and scale_maxcons)
  3. ADBM can now be trigerred by either extinctions (default) or periodically (controlled by model_parameters keywords adbm_trigger = :interval and adbm_interval wich is 100 by default)

evadelmas and others added 29 commits April 4, 2019 14:30
* error not reproducible locally, solved by updating packages
Scaling of biological rates controlled by new keywords scale_growth, scale_metabolism and scale_maxcons (could help with #74)
New keywords adbm_trigger and adbm_interval control how rewiring is triggered for the adbm model, + ✅ and 📝
@codecov
Copy link

codecov bot commented Jul 5, 2019

Codecov Report

Merging #83 into master will increase coverage by 3.48%.
The diff coverage is 98.83%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #83      +/-   ##
=========================================
+ Coverage   84.71%   88.2%   +3.48%     
=========================================
  Files          16      15       -1     
  Lines        1001     907      -94     
=========================================
- Hits          848     800      -48     
+ Misses        153     107      -46
Impacted Files Coverage Δ
src/measures.jl 38.88% <0%> (-2.19%) ⬇️
src/rewiring/parameters/checkParameters.jl 100% <100%> (ø) ⬆️
src/simulate.jl 100% <100%> (+7.4%) ⬆️
src/dBdt.jl 100% <100%> (ø) ⬆️
src/rewiring/GilljamRewire.jl 100% <100%> (ø) ⬆️
src/rewiring/ADBM.jl 100% <100%> (+4.34%) ⬆️
src/rewiring/parameters/updateParameters.jl 98.18% <100%> (-0.6%) ⬇️
src/make_parameters.jl 98.12% <98.61%> (-0.49%) ⬇️
src/checks.jl 27.27% <0%> (-1.62%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5aaa93...5a26d78. Read the comment docs.

@coveralls
Copy link

coveralls commented Jul 5, 2019

Coverage Status

Coverage increased (+3.7%) to 88.164% when pulling 5a26d78 on next into c5aaa93 on master.

@evadelmas evadelmas merged commit eb3b66b into master Sep 5, 2019
@evadelmas evadelmas deleted the next branch September 5, 2019 13:06
@evadelmas evadelmas restored the next branch September 5, 2019 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DomainError for some values of the hill exponent
2 participants