addressing issue #132 #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
for unpaired data, if a primer pair file is provided, we now use that information to determine which NT's to trim |
|
Hi Chrissy, thank you so much for working on these important issues! Do you have an estimate of when you will be ready to merge your code changes? Are you thinking of a new version tag after this? Thank you very much! |
|
Hi @khyox! We will be looking to bump versions after this merge. Review is still in progress, should be within the next few weeks |
|
Thank you so much for your reply and for your work on the merge, Chrissy! We will be looking forward to it and the version bump. |
This reverts commit 75eb684.
…rom Makefile that was meant to correct compile error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addressing issue #132, allowing both forward and reverse primers to be trimmed from a strand if the primer pair file is passed using the experimental -f flag. issue raised for small insert sizes by a user.