-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional Autofill KPI pixels #2943
Conversation
@amddg44 - Tests look good with one exception: the parameters contains |
Nice catch - |
Task/Issue URL: https://app.asana.com/0/1201462886803403/1207473407455292/f & https://app.asana.com/0/1201462886803403/1207512213117504/f iOS PR: duckduckgo/iOS#2943 macOS PR: duckduckgo/macos-browser#2856 What kind of version bump will this require?: Minor Description: Updates enabled user pixel firing rules and adds new autofill toggle pixel for search DAUs
…ill-kpis # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
# By Mariusz Śpiewak (4) and others # Via GitHub (1) and others * main: Additional Autofill KPI pixels (#2943) Prevent duplicate attribution (#2956) Release 7.125.0-2 (#2969) Disable ad attribution reporting (#2968) Fix haptic feedback for refresh control (#2942) Release 7.125.0-1 (#2966) Add two more pixels to the dashboard experiment (#2963) VPN state workarounds (#2938) RMF: New "Interacted With Message" matching attribute (#2947) Release 7.125.0-0 (#2962) don't refresh swipe tabs data source if autoclearing (#2960) Fall back to accentColor for iOS 15 and below (#2952) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Task/Issue URL: https://app.asana.com/0/1201462886803403/1207512213117497/f
Tech Design URL:
Additional Task URL: https://app.asana.com/0/1201462886803403/1207512213117504/f
Description:
Updates enabled user pixel firing rules and adds new autofill toggle pixel for search DAUs. Also adds new Autofill debug feature to bulk add dummy data for testing.
Steps to test this PR:
Notes:
m_autofill_toggled_on
/ m_autofill_toggled_off pixels fire with users first search of the day and include a parameter of number of logins a user has savedm_autofill_enableduser
pixel fires with users first search of the day, if user has 10+ logins saved and (now additionally as part of this PR) had autofill enabledm_autofill_toggled_on
pixel when Autofill enabledfill.dev
m_autofill_toggled_on
is fired with the parametercount_bucket
=some
m_autofill_toggled_off
pixel when Autofill disabledfill.dev
Save and autofill passwords
switch toOFF
m_autofill_toggled_off
is fired with the parametercount_bucket
=some
m_autofill_enableduser
pixel when Autofill enabledfill.dev
m_autofill_enableduser
is firedm_autofill_enableduser
pixel when Autofill disabledfill.dev
Save and autofill passwords
switch toOFF
m_autofill_enableduser
NOT fired<!—
Before submitting a PR, please ensure you have tested the combinations you expect the reviewer to test, then delete configurations you know do not need explicit testing.
Using a simulator where a physical device is unavailable is acceptable.
—>
Device Testing:
—
Internal references:
Software Engineering Expectations
Technical Design Template