Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Autofill KPI pixels #2943

Merged
merged 8 commits into from
Jun 19, 2024
Merged

Additional Autofill KPI pixels #2943

merged 8 commits into from
Jun 19, 2024

Conversation

amddg44
Copy link
Contributor

@amddg44 amddg44 commented Jun 12, 2024

Task/Issue URL: https://app.asana.com/0/1201462886803403/1207512213117497/f
Tech Design URL:
Additional Task URL: https://app.asana.com/0/1201462886803403/1207512213117504/f

Description:
Updates enabled user pixel firing rules and adds new autofill toggle pixel for search DAUs. Also adds new Autofill debug feature to bulk add dummy data for testing.

Steps to test this PR:
Notes:
m_autofill_toggled_on / m_autofill_toggled_off pixels fire with users first search of the day and include a parameter of number of logins a user has saved
m_autofill_enableduser pixel fires with users first search of the day, if user has 10+ logins saved and (now additionally as part of this PR) had autofill enabled

  • Test m_autofill_toggled_on pixel when Autofill enabled
  1. Starting with a new install, go to Settings > All debug options > Autofill Settings
  2. Tap “Add Test Autofill Data” and choose to add 5 logins for fill.dev
  3. Go to the Passwords screen and confirm the toggle is on and the new logins are present
  4. Go to a tab and perform a search.
  5. Confirm the pixel m_autofill_toggled_on is fired with the parameter count_bucket = some
  • Test m_autofill_toggled_off pixel when Autofill disabled
  1. Starting with a new install, go to Settings > All debug options > Autofill Settings
  2. Tap “Add Test Autofill Data” and choose to add 5 logins for fill.dev
  3. Go to the Passwords screen and confirm the toggle is on and the new logins are present
  4. Toggle the Save and autofill passwords switch to OFF
  5. Go to a tab and perform a search.
  6. Confirm the pixel m_autofill_toggled_off is fired with the parameter count_bucket = some
  • Test m_autofill_enableduser pixel when Autofill enabled
  1. Starting with a new install, go to Settings > All debug options > Autofill Settings
  2. Tap “Add Test Autofill Data” and choose to add 10+ logins for fill.dev
  3. Go to the Passwords screen and confirm the toggle is on and the new logins are present
  4. Go to a tab and perform a search.
  5. Confirm the pixel m_autofill_enableduser is fired
  • Test m_autofill_enableduser pixel when Autofill disabled
  1. Starting with a new install, go to Settings > All debug options > Autofill Settings
  2. Tap “Add Test Autofill Data” and choose to add 10+ logins for fill.dev
  3. Go to the Passwords screen and confirm the toggle is on and the new logins are present
  4. Toggle the Save and autofill passwords switch to OFF
  5. Go to a tab and perform a search.
  6. Confirm the pixel m_autofill_enableduser NOT fired

<!—
Before submitting a PR, please ensure you have tested the combinations you expect the reviewer to test, then delete configurations you know do not need explicit testing.

Using a simulator where a physical device is unavailable is acceptable.
—>

Device Testing:

  • iPhone 14 Pro

Internal references:

Software Engineering Expectations
Technical Design Template

@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Jun 13, 2024
@amddg44 amddg44 removed the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Jun 13, 2024
@amddg44 amddg44 marked this pull request as ready for review June 13, 2024 09:52
@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Jun 13, 2024
@amddg44 amddg44 removed the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Jun 13, 2024
@github-actions github-actions bot added bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project and removed bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project labels Jun 13, 2024
@amddg44 amddg44 requested review from a team, SabrinaTardio and graeme and removed request for a team and SabrinaTardio June 13, 2024 11:40
@graeme
Copy link
Contributor

graeme commented Jun 17, 2024

@amddg44 - Tests look good with one exception: the parameters contains ["count_bucket": "some"] rather than ["bucket_name": "some"]. Is this just incorrect test steps description or an actual issue?

@amddg44
Copy link
Contributor Author

amddg44 commented Jun 17, 2024

@amddg44 - Tests look good with one exception: the parameters contains ["count_bucket": "some"] rather than ["bucket_name": "some"]. Is this just incorrect test steps description or an actual issue?

Nice catch - count_bucket is the correct parameter name, I had named it incorrectly in the test steps which I’ve now updated, thanks!

amddg44 added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Jun 19, 2024
Task/Issue URL: https://app.asana.com/0/1201462886803403/1207473407455292/f & https://app.asana.com/0/1201462886803403/1207512213117504/f
iOS PR: duckduckgo/iOS#2943
macOS PR: duckduckgo/macos-browser#2856
What kind of version bump will this require?: Minor

Description:
Updates enabled user pixel firing rules and adds new autofill toggle pixel for search DAUs
…ill-kpis

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
@amddg44 amddg44 merged commit faac727 into main Jun 19, 2024
14 checks passed
@amddg44 amddg44 deleted the anya/additional-autofill-kpis branch June 19, 2024 19:04
samsymons added a commit that referenced this pull request Jun 20, 2024
# By Mariusz Śpiewak (4) and others
# Via GitHub (1) and others
* main:
  Additional Autofill KPI pixels (#2943)
  Prevent duplicate attribution (#2956)
  Release 7.125.0-2 (#2969)
  Disable ad attribution reporting (#2968)
  Fix haptic feedback for refresh control (#2942)
  Release 7.125.0-1 (#2966)
  Add two more pixels to the dashboard experiment (#2963)
  VPN state workarounds (#2938)
  RMF: New "Interacted With Message" matching attribute (#2947)
  Release 7.125.0-0 (#2962)
  don't refresh swipe tabs data source if autoclearing (#2960)
  Fall back to accentColor for iOS 15 and below (#2952)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants