Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414235014887631/1207577042982475/f
Tech Design URL:
CC:
Description:
This PR updates the attribution sender to be extra sure we can't send the pixel multiple times.
Steps to test this PR:
To test this PR means forcing the attribution call to take a few seconds.
try await Task.sleep(interval: .seconds(10))
into thereportAttributionIfNeeded
function, adding it on line 66 right above the pixel call would be fineDevice Testing:
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template