Prevent duplicate attribution #2956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is so that multiple Tasks being spawns to attempt attribution will not cause a rarer version of the problem this PR fixes.
samsymons
commented
Jun 14, 2024
| final class AdAttributionPixelReporter { | ||
| final actor AdAttributionPixelReporter { |
There was a problem hiding this comment.
Changing this to an actor so that multiple detached Tasks trying to report attribution at once will behave as we'd like.
dus7
approved these changes
Jun 18, 2024
samsymons
added a commit
that referenced
this pull request
Jun 20, 2024
# By Mariusz Śpiewak (4) and others # Via GitHub (1) and others * main: Additional Autofill KPI pixels (#2943) Prevent duplicate attribution (#2956) Release 7.125.0-2 (#2969) Disable ad attribution reporting (#2968) Fix haptic feedback for refresh control (#2942) Release 7.125.0-1 (#2966) Add two more pixels to the dashboard experiment (#2963) VPN state workarounds (#2938) RMF: New "Interacted With Message" matching attribute (#2947) Release 7.125.0-0 (#2962) don't refresh swipe tabs data source if autoclearing (#2960) Fall back to accentColor for iOS 15 and below (#2952) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414235014887631/1207577042982475/f
Tech Design URL:
CC:
Description:
This PR updates the attribution sender to be extra sure we can't send the pixel multiple times.
Steps to test this PR:
To test this PR means forcing the attribution call to take a few seconds.
try await Task.sleep(interval: .seconds(10))into thereportAttributionIfNeededfunction, adding it on line 66 right above the pixel call would be fineDevice Testing:
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template