Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RMF: New "Interacted With Message" matching attribute #2947

Merged
merged 8 commits into from
Jun 17, 2024

Conversation

amddg44
Copy link
Contributor

@amddg44 amddg44 commented Jun 13, 2024

Task/Issue URL: https://app.asana.com/0/1201462886803403/1207560754137946/f
Tech Design URL:
CC:

Description:
Allows including/filtering users that interacted with a previous remote message

Steps to test this PR:

  1. Update the RemoteMessageRequest.swift debug url to: https://www.jsonblob.com/api/1250471336743919616
  2. Launch the app and confirm the first message is presented in a new tab
  3. Interact with the message to dismiss it
  4. Re-launch the app and confirm none of the remaining 3 messages are shown

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@amddg44 amddg44 changed the title Anya/rmf interacted with message RMF: New "Interacted With Message" matching attribute Jun 13, 2024
@amddg44 amddg44 requested a review from samsymons June 13, 2024 16:06
…ith-message

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
#	DuckDuckGo/RemoteMessaging.swift
#	DuckDuckGoTests/RemoteMessagingStoreTests.swift
amddg44 added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Jun 17, 2024
Task/Issue URL: https://app.asana.com/0/1201462886803403/1207560754137946/f
iOS PR: duckduckgo/iOS#2947
macOS PR: duckduckgo/macos-browser#2860
What kind of version bump will this require?: Minor

Description:
Allows including/filtering users that interacted with a previous remote message
@amddg44 amddg44 merged commit a67c087 into main Jun 17, 2024
14 checks passed
@amddg44 amddg44 deleted the anya/rmf-interacted-with-message branch June 17, 2024 20:00
samsymons added a commit that referenced this pull request Jun 20, 2024
# By Mariusz Śpiewak (4) and others
# Via GitHub (1) and others
* main:
  Additional Autofill KPI pixels (#2943)
  Prevent duplicate attribution (#2956)
  Release 7.125.0-2 (#2969)
  Disable ad attribution reporting (#2968)
  Fix haptic feedback for refresh control (#2942)
  Release 7.125.0-1 (#2966)
  Add two more pixels to the dashboard experiment (#2963)
  VPN state workarounds (#2938)
  RMF: New "Interacted With Message" matching attribute (#2947)
  Release 7.125.0-0 (#2962)
  don't refresh swipe tabs data source if autoclearing (#2960)
  Fall back to accentColor for iOS 15 and below (#2952)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants