Update cbor-gen #117
Closed
Update cbor-gen #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
force-pushed
the
rvagg/cborgen_upd
branch
2 times, most recently
from
405dfea
to
6c31c2a
Compare
|
Note cbor_gen.go was both codegen'd and also edited, so we have a combination of native cbor-gen and the edits that we had to do here to make it work properly .. I do wonder if we shouldn't upstream some of this, specifically that cbor-gen still wants to do cbor big ints but we always use bytes for them. |
|
Marking as draft until issues raised in filecoin-project/go-state-types#242 are resolved |
rvagg
force-pushed
the
rvagg/cborgen_upd
branch
from
6c31c2a
to
cbffebb
Compare
|
Updated for master now that whyrusleeping/cbor-gen#94 is merged; but this is also now low priority as we no longer have breakage and the diff is relatively meaningless |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: whyrusleeping/cbor-gen#92