v13: make AggregateProofType optional on ProveCommitSectors3Params & ProveReplicaUpdates3Params #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 6, 2024
magik6k
force-pushed
the
feat/ddo-types-nv22
branch
9 times, most recently
from
3caa357
to
a6102ce
Compare
…ProveReplicaUpdates3Params Ref: filecoin-project/FIPs#934
rvagg
force-pushed
the
rvagg/aggregate_proof_type_optional
branch
3 times, most recently
from
413ecc6
to
be23e90
Compare
|
Updated using a version of cbor-gen that combines both whyrusleeping/cbor-gen#94 and whyrusleeping/cbor-gen#93; so we get backward compatibility and don't need the hamt and amt changes and we get nullable ints. CI will fail until those are merged, mainly for the |
rvagg
force-pushed
the
rvagg/aggregate_proof_type_optional
branch
2 times, most recently
from
39671b7
to
99666de
Compare
rvagg
force-pushed
the
rvagg/aggregate_proof_type_optional
branch
from
99666de
to
a055f35
Compare
Stebalien
approved these changes
Feb 7, 2024
magik6k
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: filecoin-project/FIPs#934
Depends on:
Update cbor-gen go-hamt-ipld#117Update cbor-gen go-amt-ipld#87But I think that whyrusleeping/cbor-gen#92 is going to cause us grief so we may have to deal with that before we move ahead here. It breaks everything that uses cbor-gen unless updated and in lotus we depend on older versions of the hamt and amt via specs-actors so this change here doesn't even work in lotus.Update: whyrusleeping/cbor-gen#93 merged along with whyrusleeping/cbor-gen#94 which solves the const->var dramas. This is good to go.