-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
turn max length consts into global vars #92
Conversation
steb im still eventually interested in getting a thumbs up from you but it seems low risk enough to merge this |
Can we make it an option during codegen instead? Maybe a new
Etc? Globals like this can make two different seemingly compatible libraries can't actually be used together. |
Hm. Even better: type Gen struct {
TupleEncoding []any
MapEncoding []any
PackageName string
MaxByteLength int // 0 for default
MaxArrayLength int // 0 for default
}
func (g *Gen) WriteTo(filename string) error {
// ...
} (or something like that) |
Oh i like that appoach |
Sometimes you just want to set these globally