feat: set background inside config module projekt0n#60 projekt0n#116

CHANGELOG.md

@@ -28,6 +28,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - `pmenu.select` color removed
 - pmenu select background color with dynamic blue color
 - breaking change: terminal colors are renamed
+- feat: set `vim.o.background` with config module (re-patch #60 #116)
 
 ### Fixes
 

README.md

@@ -81,8 +81,6 @@ require('github-theme').setup()
 
 ## Configuration
 
-> Note: set `vim.o.background = "light"` before loading light github colorschemes.
-
 | Option                   | Default  | Description                                                                                                                                                     |
 | ------------------------ | -------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------- |
 | theme_style              | `dark`   | Set theme variant (options: `dark`/`dark_default`/`dimmed`/`light`/`light_default`)                                                                             |
@@ -101,13 +99,13 @@ require('github-theme').setup()
 
 ```vim
 " Example config in VimScript
-" configuration needs to be set BEFORE loading the color scheme with `colorscheme` command
+" NOTE: Configuration needs to be set BEFORE loading the color scheme with `colorscheme` command
 let g:github_function_style = "italic"
 let g:github_sidebars = ["qf", "vista_kind", "terminal", "packer"]
 
 " Change the "hint" color to the "orange" color, and make the "error" color bright red
 let g:github_colors = {
-  \ 'hint': 'orange',
+  \ 'hint: 'orange',
   \ 'error': '#ff0000'
 \ }
 

lua/github-theme/config.lua

@@ -38,6 +38,11 @@ config = {
   transform_colors = false
 }
 
+-- setting light background
+local light_background = {["light"] = true, ["light_default"] = true}
+
+if light_background[config.theme_style] then vim.o.background = "light" end
+
 ---@param user_config Config
 local function apply_configuration(user_config)
   for key, value in pairs(user_config) do