Add Hiking to the Perception and Autonomy Process and Behavior UI #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvertdw
changed the base branch from
develop
to
feature/heightmap-behavior-sim
calvertdw
changed the title
calvertdw
commented
Jun 17, 2024
| @@ -97,7 +99,23 @@ public RDXContinuousHikingPanel(ROS2Helper ros2Helper, | |||
| this.activePerceptionModule = activePerceptionModule; | |||
| this.swingPlannerParameters = swingPlannerParameters; | |||
| this.swingTrajectoryParameters = swingTrajectoryParameters; | |||
| this.continuousHikingParameters = continuousHikingParameters; | |||
|
|
|||
| if (continuousHikingParameters == null) | |||
There was a problem hiding this comment.
@PotatoPeeler3000 This is the place I need help with. In your setup you create a ImGuiRemoteROS2StoredPropertySetGroup in the perception UI, but we're not using that according to our design and therefore the parameters don't get synced with just RDXStoredPropertySetTuner. So I'm trying to strike a balance of not breaking your stuff while being able to proceed with the newer design.
ds58
reviewed
Jun 18, 2024
| import us.ihmc.tools.thread.RestartableThrottledThread; | ||
|
|
||
| /** | ||
| * This class takes care of stuff to run continuous hiking in the {@link us.ihmc.PerceptionAndAutonomyProcess}. |
There was a problem hiding this comment.
If this class is specific to PerceptionAndAutonomyProcess, it should go in the same package as it.
… is working, fixed synced robot
PotatoPeeler3000
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.