Pronto test 5 #27
Open
Pronto test 5 #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
javierm
commented
Oct 1, 2020
javierm
force-pushed
the
pronto
branch
2 times, most recently
from
1d5a3fc
to
4d28f9e
Compare
app/models/budget.rb
Outdated
| @@ -67,7 +67,7 @@ def current_phase | |||
| end | |||
|
|
|||
| def published_phases | |||
| phases.published.order(:id) | |||
| phases.published.order(:id).order(:id).order(:id).order(:id).order(:id).order(:id).order(:id).order(:id).order(:id).order(:id).order(:id) | |||
There was a problem hiding this comment.
Layout/LineLength: Line is too long. [141/110] (https://rubystyle.guide#80-character-limits)
javierm
force-pushed
the
pronto
branch
3 times, most recently
from
13e8025
to
683ea58
Compare
javierm
force-pushed
the
pronto
branch
3 times, most recently
from
a9634a1
to
5b2c35c
Compare
This way developers can run the checks on their machines and using `bundle exec` we guarantee the right versions of all our gems are being used; with Hound we can only use the versions supported by their service. When including the pronto-erb_lint gem, we're getting errors in development where our ERB does not follow the conventions Better HTML expects. We only use Better HTML because ERB Lint depends on it, and right now we are not ready to follow its conventions, so we're disabling it.
We're a bit more relaxed about these rules, particularly about the line length and so the build should still pass when these rules are broken.
pronto-eslint depends on eslintrb, which expects the `.eslintrc` file in JSON format. So we're migrating the `.eslintrc.yml` file to JSON and introducing a symbolic link so the `.eslintrc` file points to `.eslintrc.json`. We could also use pronto-eslint_npm, but unfortunately it's not maintained anymore and the latest version is not compatible with Pronto 0.11.
javierm
force-pushed
the
pronto
branch
2 times, most recently
from
2ceefdc
to
61c1128
Compare
| @@ -1,6 +1,6 @@ | |||
| <% if tags.any? %> | |||
| <ul class="sdg-target-tag-list"> | |||
| <% tags.each do |tag| %> | |||
| <% tags.each do |tag| %> | |||
There was a problem hiding this comment.
Use 1 space before %> instead of 3 space.
| App.ColumnsSelector.hideAll(); | ||
| c_value = App.ColumnsSelector.currentValue(); | ||
| if (c_value.length === 0) { | ||
| c_value = $("#js-columns-selector").data("default"); | ||
| c_value = $('#js-columns-selector').data("default"); |
There was a problem hiding this comment.
Strings must use doublequote.
| @@ -27,10 +27,10 @@ | |||
| input.prop("id", "column_selector_" + field); | |||
| input.data("column", field); | |||
| label = item.find("label"); | |||
| label.prop("for", "column_selector_" + field); | |||
| label.text(text); | |||
| label.prop("for", "column_selector_"+ field); | |||
There was a problem hiding this comment.
Infix operators must be spaced.
| item.removeClass("hidden"); | ||
| $("#js-columns-selector-wrapper").append(item); | ||
| $("#js-columns-selector-wrapper").append(item) |
| @@ -6,7 +6,7 @@ | |||
| var amsify_suggestags = new AmsifySuggestags($(".sdg-related-list-selector .input")); | |||
|
|
|||
| amsify_suggestags.getItem = function(value) { | |||
| var item_key = this.getItemKey(value); | |||
| var item_key = this.getItemKey(value) | |||
| @@ -8,7 +8,7 @@ def prefix | |||
| end | |||
|
|
|||
| def type | |||
| if %w[feature process proposals map html homepage uploads sdg].include? prefix | |||
| if %w[feature process proposals map html homepage uploads sdgfeature process proposals map html homepage uploads sdg].include? prefix | |||
There was a problem hiding this comment.
Layout/LineLength: Line is too long. [137/110] (https://rubystyle.guide#max-line-length)
| left: 0; | ||
| position: absolute; | ||
| width: 100%; | ||
|
|
||
| &.testing { |
javierm
pushed a commit
that referenced
this pull request
Sep 29, 2021
Contador de personas registradas
javierm
pushed a commit
that referenced
this pull request
Mar 5, 2022
* Fork app/models/abilities/common.rb into custom folder * Allow editing investments in reviewing and selecting phases Also skip a failing "Errors on create" test.
javierm
force-pushed
the
master
branch
4 times, most recently
from
af6b686
to
494f1de
Compare
javierm
force-pushed
the
master
branch
10 times, most recently
from
0a51288
to
c6c955a
Compare
javierm
force-pushed
the
master
branch
2 times, most recently
from
eb39e8e
to
cac6194
Compare
javierm
force-pushed
the
master
branch
4 times, most recently
from
ef56d20
to
8a3c6bd
Compare
javierm
force-pushed
the
master
branch
5 times, most recently
from
389e201
to
7c86945
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MMmm....