-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pronto test 5 #27
base: master
Are you sure you want to change the base?
Pronto test 5 #27
Conversation
1d5a3fc
to
4d28f9e
Compare
app/models/budget.rb
Outdated
@@ -67,7 +67,7 @@ def current_phase | |||
end | |||
|
|||
def published_phases | |||
phases.published.order(:id) | |||
phases.published.order(:id).order(:id).order(:id).order(:id).order(:id).order(:id).order(:id).order(:id).order(:id).order(:id).order(:id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Layout/LineLength: Line is too long. [141/110] (https://rubystyle.guide#80-character-limits)
13e8025
to
683ea58
Compare
a9634a1
to
5b2c35c
Compare
This way developers can run the checks on their machines and using `bundle exec` we guarantee the right versions of all our gems are being used; with Hound we can only use the versions supported by their service. When including the pronto-erb_lint gem, we're getting errors in development where our ERB does not follow the conventions Better HTML expects. We only use Better HTML because ERB Lint depends on it, and right now we are not ready to follow its conventions, so we're disabling it.
We're a bit more relaxed about these rules, particularly about the line length and so the build should still pass when these rules are broken.
pronto-eslint depends on eslintrb, which expects the `.eslintrc` file in JSON format. So we're migrating the `.eslintrc.yml` file to JSON and introducing a symbolic link so the `.eslintrc` file points to `.eslintrc.json`. We could also use pronto-eslint_npm, but unfortunately it's not maintained anymore and the latest version is not compatible with Pronto 0.11.
2ceefdc
to
61c1128
Compare
@@ -1,6 +1,6 @@ | |||
<% if tags.any? %> | |||
<ul class="sdg-target-tag-list"> | |||
<% tags.each do |tag| %> | |||
<% tags.each do |tag| %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use 1 space before %>
instead of 3 space.
App.ColumnsSelector.hideAll(); | ||
c_value = App.ColumnsSelector.currentValue(); | ||
if (c_value.length === 0) { | ||
c_value = $("#js-columns-selector").data("default"); | ||
c_value = $('#js-columns-selector').data("default"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strings must use doublequote.
@@ -27,10 +27,10 @@ | |||
input.prop("id", "column_selector_" + field); | |||
input.data("column", field); | |||
label = item.find("label"); | |||
label.prop("for", "column_selector_" + field); | |||
label.text(text); | |||
label.prop("for", "column_selector_"+ field); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Infix operators must be spaced.
item.removeClass("hidden"); | ||
$("#js-columns-selector-wrapper").append(item); | ||
$("#js-columns-selector-wrapper").append(item) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing semicolon.
@@ -6,7 +6,7 @@ | |||
var amsify_suggestags = new AmsifySuggestags($(".sdg-related-list-selector .input")); | |||
|
|||
amsify_suggestags.getItem = function(value) { | |||
var item_key = this.getItemKey(value); | |||
var item_key = this.getItemKey(value) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing semicolon.
@@ -8,7 +8,7 @@ def prefix | |||
end | |||
|
|||
def type | |||
if %w[feature process proposals map html homepage uploads sdg].include? prefix | |||
if %w[feature process proposals map html homepage uploads sdgfeature process proposals map html homepage uploads sdg].include? prefix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Layout/LineLength: Line is too long. [137/110] (https://rubystyle.guide#max-line-length)
left: 0; | ||
position: absolute; | ||
width: 100%; | ||
|
||
&.testing { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Empty rule
Contador de personas registradas
* Fork app/models/abilities/common.rb into custom folder * Allow editing investments in reviewing and selecting phases Also skip a failing "Errors on create" test.
af6b686
to
494f1de
Compare
0a51288
to
c6c955a
Compare
eb39e8e
to
cac6194
Compare
ef56d20
to
8a3c6bd
Compare
389e201
to
7c86945
Compare
MMmm....