Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pronto test 5 #27

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Pronto test 5 #27

wants to merge 4 commits into from

Commits on Feb 8, 2021

  1. Use Pronto to check code conventions 

    This way developers can run the checks on their machines and using
`bundle exec` we guarantee the right versions of all our gems are being
used; with Hound we can only use the versions supported by their
service.

When including the pronto-erb_lint gem, we're getting errors in
development where our ERB does not follow the conventions Better HTML
expects.

We only use Better HTML because ERB Lint depends on it, and right now we
are not ready to follow its conventions, so we're disabling it.
    @javierm
    javierm committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    589269e View commit details
    Browse the repository at this point in the history

  2. Don't fail the build on "refactoring" offenses 

    We're a bit more relaxed about these rules, particularly about the line
length and so the build should still pass when these rules are broken.
    @javierm
    javierm committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    e24d18c View commit details
    Browse the repository at this point in the history

  3. Make ESLint configuration compatible with Pronto 

    pronto-eslint depends on eslintrb, which expects the `.eslintrc` file
in JSON format. So we're migrating the `.eslintrc.yml` file to JSON and
introducing a symbolic link so the `.eslintrc` file points to
`.eslintrc.json`.

We could also use pronto-eslint_npm, but unfortunately it's not
maintained anymore and the latest version is not compatible with Pronto
0.11.
    @javierm
    javierm committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    7920b72 View commit details
    Browse the repository at this point in the history

  4. Fail

    @javierm
    javierm committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    0466615 View commit details
    Browse the repository at this point in the history