Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pronto test 5 #27

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .eslintrc
115 changes: 115 additions & 0 deletions .eslintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,115 @@
{
"env": {
"browser": true,
"es6": false
},
"extends": "eslint:recommended",
"globals": {
"$": "readonly",
"App": "readonly",
"AmsifySuggestags": "readonly",
"annotator": "readonly",
"c3": "readonly",
"CKEDITOR": "readonly",
"L": "readonly",
"Turbolinks": "readonly"
},
"parserOptions": {
"ecmaVersion": 5
},
"rules": {
"array-bracket-spacing": "error",
"array-callback-return": "error",
"block-spacing": "error",
"brace-style": "error",
"comma-spacing": "error",
"computed-property-spacing": "error",
"curly": "error",
"dot-notation": "error",
"eol-last": "error",
"eqeqeq": [
"error",
"always",
{
"null": "ignore"
}
],
"func-call-spacing": "error",
"indent": [
"error",
2
],
"key-spacing": "error",
"keyword-spacing": "error",
"linebreak-style": "error",
"lines-between-class-members": "error",
"max-len": [
"warn",
{
"code": 110
}
],
"no-array-constructor": "error",
"no-console": "error",
"no-multi-spaces": "error",
"no-multiple-empty-lines": [
"error",
{
"max": 1
}
],
"no-param-reassign": "error",
"no-shadow": "error",
"no-spaced-func": "error",
"no-tabs": "error",
"no-trailing-spaces": "error",
"no-void": "error",
"no-whitespace-before-property": "error",
"object-curly-spacing": [
"error",
"always",
{
"objectsInObjects": false
}
],
"padded-blocks": [
"error",
"never"
],
"quotes": [
"error",
"double",
{
"avoidEscape": true
}
],
"semi": [
"error",
"always"
],
"semi-spacing": "error",
"space-before-blocks": "error",
"space-before-function-paren": [
"error",
"never"
],
"space-in-parens": "error",
"space-infix-ops": "error",
"space-unary-ops": "error",
"spaced-comment": [
"error",
"always",
{
"markers": [
"="
],
"exceptions": [
"-"
]
}
],
"strict": "error",
"switch-colon-spacing": "error",
"yoda": "error"
}
}
85 changes: 0 additions & 85 deletions .eslintrc.yml

This file was deleted.

22 changes: 22 additions & 0 deletions .github/workflows/linters.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
name: linters
on: [pull_request]

jobs:
linters:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v2
- run: |
git fetch --no-tags --prune origin +refs/heads/*:refs/remotes/origin/*
- name: Setup Ruby
uses: ruby/setup-ruby@v1
with:
bundler-cache: true
- name: Setup NPM
uses: actions/setup-node@v1
- name: Install eslint
run: npm install --global [email protected]
- name: Run Pronto
run: |
PRONTO_PULL_REQUEST_ID="$(jq --raw-output .number "$GITHUB_EVENT_PATH")" PRONTO_GITHUB_ACCESS_TOKEN="${{ github.token }}" bundle exec pronto run -f github_status github_pr -c origin/${{ github.base_ref }}
11 changes: 0 additions & 11 deletions .hound.yml

This file was deleted.

5 changes: 5 additions & 0 deletions .pronto.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
rubocop:
suggestions: true
severities:
refactor: info
convention: warning
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ If you'd like us to review your pull request in good spirits, please follow our

* Include specs to test any changes you've made
* Our CI will check whether the rest of the application is still working properly; check its build and make sure all tests are passing
* Your pull request will be automatically reviewed by Hound CI; fix any issues it reports
* Run `bundle exec pronto run` and fix any issues it reports; these issues will also be automatically reported on the pull request
* Follow [the seven rules of a great commit message](https://chris.beams.io/posts/git-commit/)

When we review your pull request and ask for changes, if you're proficient using `git rebase` edit existing commits instead of adding new ones. If you aren't proficient with `git rebase`, ignore this point.
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING_ES.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ Si quieres que revisemos tu código con una sonrisa, por favor sigue nuestras co

* Incluye tests para los cambios que hayas hecho
* Los tests se ejecutarán automáticamente para comprobar que el resto de la aplicación sigue funcionando; asegúrate de que los tests pasan
* Tus cambios serán revisados automáticamente por Hound CI; arregla los problemas de los que informa (si es que hay alguno)
* Ejecuta `bundle exec pronto run` y arregla los problemas de los que informe (si es que hay alguno)
* Sigue [las siete reglas para un gran mensaje de commit](https://chris.beams.io/posts/git-commit/)

Cuando revisemos tu código y te pidamos que cambies alguna cosa, si tienes experiencia con `git rebase` edita los commits existentes en vez de añadir más. Si no tienes experiencia con `git rebase`, puedes saltarte este punto.
Expand Down
5 changes: 5 additions & 0 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,11 @@ group :development do
gem "erb_lint", "~> 0.0.35", require: false
gem "github_changelog_generator", "~> 1.15.2"
gem "mdl", "~> 0.11.0", require: false
gem "pronto", "~> 0.11.0"
gem "pronto-erb_lint", "~> 0.1.5"
gem "pronto-eslint", "~> 0.11.0"
gem "pronto-rubocop", "~> 0.11.0"
gem "pronto-scss", "~> 0.11.0"
gem "rubocop", "~> 0.91.0", require: false
gem "rubocop-performance", "~> 1.7.1", require: false
gem "rubocop-rails", "~> 2.6.0", require: false
Expand Down
Loading