Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RAPIDS headers from libucxx #22

Merged
merged 2 commits into from
Apr 6, 2023

Conversation

jakirkham
Copy link
Member

Fixes #20

This is a workaround to remove RAPIDS headers from libucxx. Ideally they shouldn't be installed in the first place. However for now just remove them to avoid issues.

This is a workaround to remove RAPIDS headers from `libucxx`. Ideally
they shouldn't be installed in the first place. However for now just
remove them to avoid issues.
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks John!

@pentschev pentschev merged commit 1b44da9 into rapidsai:main Apr 6, 2023
@jakirkham jakirkham deleted the rm_conda_rapids_headers branch April 6, 2023 18:36
rapids-bot bot pushed a commit that referenced this pull request Jul 5, 2023
Currently conda builds are fetching `rmm` from CPM, rather than using conda packages. This PR aims to use conda for as many dependencies as possible to avoid repackaging and clobbering issues.

Resolves #20.

Related to #22, #54, similar to rapidsai/cudf#13230

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - https://github.com/jakirkham
  - Peter Andreas Entschev (https://github.com/pentschev)
  - Ray Douglass (https://github.com/raydouglass)

URL: #64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RAPIDS CPM headers inadvertently being installed
2 participants