Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add librmm and gtest to host environment. #64

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Jun 30, 2023

Currently conda builds are fetching rmm from CPM, rather than using conda packages. This PR aims to use conda for as many dependencies as possible to avoid repackaging and clobbering issues.

Resolves #20.

Related to #22, #54, similar to rapidsai/cudf#13230

@bdice
Copy link
Contributor Author

bdice commented Jun 30, 2023

I confirmed that this resolves #20. The dependencies are no longer being fetched by CPM (it finds the local conda packages) and the headers are not being shipped in the resulting packages from what I can see in the logs.

@bdice bdice marked this pull request as ready for review June 30, 2023 22:48
@bdice bdice requested a review from a team as a code owner June 30, 2023 22:48
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Bradley! 🙏

Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @bdice .

@pentschev
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 7add326 into rapidsai:branch-0.33 Jul 5, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RAPIDS CPM headers inadvertently being installed
4 participants