Fix RMM dependency #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pentschev
approved these changes
Jun 6, 2023
|
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Jul 5, 2023
Currently conda builds are fetching `rmm` from CPM, rather than using conda packages. This PR aims to use conda for as many dependencies as possible to avoid repackaging and clobbering issues. Resolves #20. Related to #22, #54, similar to rapidsai/cudf#13230 Authors: - Bradley Dice (https://github.com/bdice) Approvers: - https://github.com/jakirkham - Peter Andreas Entschev (https://github.com/pentschev) - Ray Douglass (https://github.com/raydouglass) URL: #64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
dependencies.yamlfile listslibrmmfor conda/pyproject/requirements, but the C++ package librmm isn't available for pyproject/requirements files. Only the Python packagermmis available as a wheel. This PR swaps the two dependencies in the list.Also I updated
gmock/gtestto align with the versions used by the rest of RAPIDS and sorted the dependency list.