[Color 4] Dart JS API implementation #2117
Conversation
* feature.color-4: (30 commits) Update for `lch()` tests (sass#2108) Add support for relative color syntax (sass#2112) Update for `oklab()` tests (sass#2094) Poke CI Cut a release (sass#2107) Implement first class mixins (sass#2073) Fix a race condition preventing embedded compiler to shutdown after a protocol error (sass#2106) Switch to the GitHub-hosted MacOS ARM64 runner (sass#2103) Update the version of Sass used by the website on release (sass#2102) Bump actions/checkout from 3 to 4 (sass#2088) Bump docker/setup-qemu-action from 2 to 3 (sass#2089) Implement support for the relative color syntax of CSS Color 5 (sass#2098) Rephrase errors for numbers that must be unitless or % (sass#2101) Forbid LLM contributions (sass#2100) Update protocol-version during embedded-host-node release (sass#2097) Deprecate Deprecation.calcInterp (sass#2096) Avoid useless allocations for interpolations without maps (sass#2095) Fix an error during embedded compiler shutdown (sass#2092) Cut a release (sass#2090) Expose the containing URL to importers under some circumstances (sass#2083) ...
|
@nex3 This is ready for an initial review. Thanks! |
Co-authored-by: Natalie Weizenbaum <[email protected]>
Co-authored-by: Natalie Weizenbaum <[email protected]>
|
It looks like the powerless channel tests need to be adjusted for sass/sass#3654 |
@nex3 Updated in sass/sass-spec@bc2bd0b I may be missing something, but it looks to me like the the remaining failing tests are cases where Dart Sass is trailing the spec (e.g. powerless channels, clamped channels, legacy color equality). Let me know if you think that's incorrect! |
|
That's very plausible. Feel free to just mark those tests as todo for now and I'll reenable them as I get the implementation into shape. |
| _toSpace(self, space).toGamut(), | ||
| 'toGamut': (SassColor self, [String? space]) { | ||
| var originalSpace = self.space; | ||
| return _toSpace(self, space).toGamut().toSpace(originalSpace); |
There was a problem hiding this comment.
That's very plausible. Feel free to just mark those tests as todo for now and I'll reenable them as I get the implementation into shape.
One of the tests was failing because of this bug, but I added comments to the rest of the failing tests (and skipped them for dart-sass for now), which I think are all caused by implementation lagging spec changes.
* feature.color-4: Poke CI Update link to Node.js releases page (sass#2131) Write implementation documentation (sass#2042) Remove dead code (sass#2129) Add compatibility with Node.js 21.0.0 (sass#2128) Bump lints from 2.1.1 to 3.0.0 (sass#2126) Bump dartdoc from 6.3.0 to 7.0.0 (sass#2118) Cut a release (sass#2120) Update pubspec and changelog for sass/embedded-host-node#257 (sass#2116) Fix crash in browser when running alongside NextJS (sass#2114) Cut another release (sass#2111)
Spec - https://github.com/sass/sass/blob/main/proposal/color-4-new-spaces-js.d.ts.md
[skip sass-embedded]