Skip to content

Commit

Permalink
Ignore nuget-diff error for now. (#917)
Browse files Browse the repository at this point in the history
Context: #916

`api-diff` currently fails for `Xamarin.AndroidX.Car.App.App` `1.4.0` which is preventing us from updating it.  The nature of this crash is documented in #916.

We have chosen not to spend the resources at this time to fix this tooling error.  Instead, we are going to go ahead and update `Xamarin.AndroidX.Car.App.App` to version `1.4.0` and are going to exclude it from running `api-diff`.
  • Loading branch information
jpobst committed Jul 3, 2024
1 parent 5f56d14 commit 0d9339b
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 2 deletions.
1 change: 1 addition & 0 deletions Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -216,5 +216,6 @@
<AndroidNamespaceReplacement Include='adselection' Replacement='AdSelection' />
<AndroidNamespaceReplacement Include='appsetid' Replacement='AppSetId' />
<AndroidNamespaceReplacement Include='customaudience' Replacement='CustomAudience' />
<AndroidNamespaceReplacement Include='mediaextensions' Replacement='MediaExtensions' />
</ItemGroup>
</Project>
4 changes: 2 additions & 2 deletions config.json
Original file line number Diff line number Diff line change
Expand Up @@ -240,8 +240,8 @@
{
"groupId": "androidx.car.app",
"artifactId": "app",
"version": "1.2.0",
"nugetVersion": "1.2.0.11",
"version": "1.4.0",
"nugetVersion": "1.4.0",
"nugetId": "Xamarin.AndroidX.Car.App.App",
"dependencyOnly": false
},
Expand Down
3 changes: 3 additions & 0 deletions nuget-diff.cake
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ if (!nupkgs.Any()) {
Warning($"##vso[task.logissue type=warning]No NuGet packages were found.");
} else {
Parallel.ForEach (nupkgs, nupkg => {
// See https://github.com/xamarin/AndroidX/issues/916
if (nupkg.FullPath.Contains ("Xamarin.AndroidX.Car.App.App"))
return;
var version = "--latest";
var versionFile = nupkg.FullPath + ".baseversion";
if (FileExists(versionFile)) {
Expand Down
8 changes: 8 additions & 0 deletions published-namespaces.txt
Original file line number Diff line number Diff line change
Expand Up @@ -93,16 +93,24 @@ AndroidX.Car.App.Annotations
AndroidX.Car.App.Connection
AndroidX.Car.App.Constraints
AndroidX.Car.App.Hardware
AndroidX.Car.App.Hardware.Climate
AndroidX.Car.App.Hardware.Common
AndroidX.Car.App.Hardware.Info
AndroidX.Car.App.Managers
AndroidX.Car.App.Media
AndroidX.Car.App.MediaExtensions
AndroidX.Car.App.Messaging
AndroidX.Car.App.Messaging.Model
AndroidX.Car.App.Model
AndroidX.Car.App.Model.Constraints
AndroidX.Car.App.Model.SignIn
AndroidX.Car.App.Navigation
AndroidX.Car.App.Navigation.Model
AndroidX.Car.App.Navigation.Model.Constraints
AndroidX.Car.App.Notification
AndroidX.Car.App.Serialization
AndroidX.Car.App.Suggestion
AndroidX.Car.App.Suggestion.Model
AndroidX.Car.App.Utils
AndroidX.Car.App.Validation
AndroidX.Car.App.Versioning
Expand Down

0 comments on commit 0d9339b

Please sign in to comment.