Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error running api-diff on Xamarin.AndroidX.Car.App.App #916

Open
jpobst opened this issue Jul 1, 2024 · 0 comments
Open

Error running api-diff on Xamarin.AndroidX.Car.App.App #916

jpobst opened this issue Jul 1, 2024 · 0 comments
Labels
tools Issues with binderator or XBD

Comments

@jpobst
Copy link
Contributor

jpobst commented Jul 1, 2024

Attempting to run api-diff on Xamarin.AndroidX.Car.App.App 1.4.0 produces the following error:

System.ArgumentOutOfRangeException
  HResult=0x80131502
  Message=Length cannot be less than zero. (Parameter 'length')
  Source=System.Private.CoreLib
  StackTrace:
   at System.String.Substring(Int32 startIndex, Int32 length)
   at Mono.ApiTools.Helper.GetTypeName(String type, State state) in C:\code\Mono.ApiTools.NuGetDiff\Mono.ApiTools.ApiDiffFormatted\Helper.cs:line 154

This code is attempting to "pretty" format the following type:

System.Collections.Generic.IDictionary`2[System.Collections.Generic.ICollection`1[AndroidX.Car.App.Hardware.Common.CarZone],System.Collections.Generic.ICollection`1[Java.Lang.Integer]]

// which recurses into:
System.Collections.Generic.ICollection`1[AndroidX.Car.App.Hardware.Common.CarZone],System.Collections.Generic.ICollection`1[Java.Lang.Integer]

// which recurses into:
AndroidX.Car.App.Hardware.Common.CarZone],System.Collections.Generic.ICollection`1[Java.Lang.Integer

Our api-diff-tools tooling is in flux currently, and we probably shouldn't prioritize this fix right now.

As such, this is the documentation for the future fix, and we will just skip running api-diff on this one package for now.
@jpobst jpobst added the tools Issues with binderator or XBD label Jul 1, 2024
@jpobst jpobst mentioned this issue Jul 2, 2024
Merged
jpobst added a commit that referenced this issue Jul 3, 2024
@jpobst
Ignore nuget-diff error for now. (#917)
0d9339b 
Context: #916

`api-diff` currently fails for `Xamarin.AndroidX.Car.App.App` `1.4.0` which is preventing us from updating it.  The nature of this crash is documented in #916.

We have chosen not to spend the resources at this time to fix this tooling error.  Instead, we are going to go ahead and update `Xamarin.AndroidX.Car.App.App` to version `1.4.0` and are going to exclude it from running `api-diff`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tools Issues with binderator or XBD
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jpobst