Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore nuget-diff error for now. #917

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Ignore nuget-diff error for now. #917

merged 1 commit into from
Jul 3, 2024

Conversation

jpobst
Copy link
Contributor

@jpobst jpobst commented Jul 1, 2024

Context: #916

api-diff currently fails for Xamarin.AndroidX.Car.App.App 1.4.0 which is preventing us from updating it. The nature of this crash is documented in #916.

We have chosen not to spend the resources at this time to fix this tooling error. Instead, we are going to go ahead and update Xamarin.AndroidX.Car.App.App to version 1.4.0 and are going to exclude it from running api-diff.

@jpobst jpobst force-pushed the android-car branch 2 times, most recently from d2e4e2b to 7056b1e Compare July 1, 2024 21:05
@jpobst jpobst marked this pull request as ready for review July 3, 2024 14:28
@jpobst jpobst requested a review from moljac July 3, 2024 14:28
Copy link
Member

@moljac moljac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Got it what intention war. Not to freeze, but to bind without api-diff/nuget-diff

@jpobst jpobst merged commit 0d9339b into main Jul 3, 2024
5 checks passed
@jpobst jpobst deleted the android-car branch July 3, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants