fix(core): we should never show vertical scroll on left frozen container #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- we should never show a vertical scroll on the left container when having a frozen grid, even when flag `alwaysShowVerticalScroll` is set to True (in that case, the flag should display a scroll ONLY for the right container)
ghiscoding-SE
pushed a commit
to ghiscoding/slickgrid-universal
that referenced
this pull request
Oct 5, 2020
- the `alwaysShowVerticalScroll` flag should be dealt directly in the core and it should never show vertical scroll on left frozen container, even when the `alwaysShowVerticalScroll` is set to True (see core lib [PR #537](6pac/SlickGrid#537))
ghiscoding
added a commit
to ghiscoding/aurelia-slickgrid
that referenced
this pull request
Oct 6, 2020
- the `alwaysShowVerticalScroll` flag should be dealt directly in the core and it should never show vertical scroll on left frozen container, even when the `alwaysShowVerticalScroll` is set to True (see core lib [PR #537](6pac/SlickGrid#537))
ghiscoding
added a commit
to ghiscoding/slickgrid-universal
that referenced
this pull request
Oct 7, 2020
#138) * feat(styling): add frozen on all possible elements with SASS variables - add frozen to both the pre-header & header columns - add SASS variables to customize border on these 3 properties (pre-header, header, header-row aka filter row) * fix(core): don't override alwaysShowVerticalScroll flag - the `alwaysShowVerticalScroll` flag should be dealt directly in the core and it should never show vertical scroll on left frozen container, even when the `alwaysShowVerticalScroll` is set to True (see core lib [PR #537](6pac/SlickGrid#537))
ghiscoding-SE
pushed a commit
to ghiscoding/Angular-Slickgrid
that referenced
this pull request
Oct 7, 2020
- the `alwaysShowVerticalScroll` flag should be dealt directly in the core and it should never show vertical scroll on left frozen container, even when the `alwaysShowVerticalScroll` is set to True (see core lib [PR #537](6pac/SlickGrid#537)) - requires core lib [PR #537](6pac/SlickGrid#537) to be merged and released
ghiscoding
added a commit
to ghiscoding/aurelia-slickgrid
that referenced
this pull request
Oct 14, 2020
* fix(core): don't override alwaysShowVerticalScroll flag - the `alwaysShowVerticalScroll` flag should be dealt directly in the core and it should never show vertical scroll on left frozen container, even when the `alwaysShowVerticalScroll` is set to True (see core lib [PR #537](6pac/SlickGrid#537))
ghiscoding
added a commit
to ghiscoding/Angular-Slickgrid
that referenced
this pull request
Oct 14, 2020
fix(core): don't override alwaysShowVerticalScroll flag - the `alwaysShowVerticalScroll` flag should be dealt directly in the core and it should never show vertical scroll on left frozen container, even when the `alwaysShowVerticalScroll` is set to True (see core lib [PR #537](6pac/SlickGrid#537)) - requires core lib [PR #537](6pac/SlickGrid#537) to be merged and released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alwaysShowVerticalScrollis set to True (in that case, the flag should display a scroll ONLY for the right container)alwaysShowVerticalScrollis only used for 1 reason, to show a vertical scroll so that the Grid Menu icon doesn't go over a header column title (see print screen 2).without the fix
with the Fix
