Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support: add LL token icon #6776

Merged
merged 7 commits into from
May 27, 2024
Merged

support: add LL token icon #6776

merged 7 commits into from
May 27, 2024

Conversation

shaynos
Copy link
Contributor

@shaynos shaynos commented Apr 29, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • Icon added only

📝 Description

Add icon for LightLink ERC20 to Ledger
Network: Ethereum Mainnet
Contract Address: 0x0921799CB1d702148131024d18fCdE022129Dc73
Etherscan: https://etherscan.io/address/0x0921799CB1d702148131024d18fCdE022129Dc73

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@shaynos shaynos requested a review from a team as a code owner April 29, 2024 23:47
@vercel Vercel
Copy link

vercel bot commented Apr 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 27, 2024 1:11am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview May 27, 2024 1:11am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 27, 2024 1:11am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 27, 2024 1:11am

@vercel Vercel
Copy link

vercel bot commented Apr 29, 2024

@shaynos is attempting to deploy a commit to the LedgerHQ Team on Vercel.

A member of the Team first needs to authorize it.

@live-github-bot live-github-bot bot added ui Has changes in the design system library fork Pull request base branch comes from a fork. labels Apr 29, 2024
gre
gre suggested changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@gre gre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

running pnpm install on this branch seems to reveal a problem on the importing of that icon

 src/native/LL.tsx:13:85 - error TS2322: Type '{ className: string; d: string; }' is not assignable to type 'IntrinsicAttributes & IntrinsicClassAttributes<Path…
│   Property 'className' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes<Path> & Readonly<PathProps>'.
│ 13   return <Svg viewBox="0 0 1200 1200" height={size} width={size} fill={color}><Path className="prefix__st0" d="M515.156 608.41c-15.329 15.328-15.329 40.774 …
│                                                                                        ~~~~~~~~~
│ Found 1 error in src/native/LL.tsx:13
│  ELIFECYCLE  Command failed with exit code 2.
└─ Failed in 21.1s at /Users/grenaudeau/dev/ledger-live/libs/ui/packages/crypto-icons

@shaynos shaynos requested a review from gre April 30, 2024 23:57
@shaynos
Copy link
Contributor Author

shaynos commented Apr 30, 2024

Thanks @gre I've cleaned up the svg, looks like it builds ok now

@shaynos
Copy link
Contributor Author

shaynos commented May 6, 2024

Hi @gre friendly reminder on this pr pls

@gre
Copy link
Contributor

gre commented May 14, 2024 •
edited
Loading

Hey @shaynos , sorry for the delay.
svg looks ok.
at the moment I don't see the LightLink token at all in our ERC20 lists ( https://support.ledger.com/hc/en-us/articles/10479755500573-Supported-Coins-and-Tokens-in-Ledger-Live?docs=true ), did you request it yet via https://developers.ledger.com/docs/tokens/integrating-tokens/evm-chains-tokens ?

thanks

@shaynos
Copy link
Contributor Author

shaynos commented May 16, 2024

Hey @gre no worries - Yes I requested the addition of LightLink token about 2 weeks ago via type form on the provided link. Is there any other actions we need to take?

Syncing this now with ledger branch...

@shaynos
Copy link
Contributor Author

shaynos commented May 22, 2024

Hi @gre looks like LightLink has now been added to supported tokens here - https://support.ledger.com/hc/en-us/articles/10479755500573-Supported-Coins-and-Tokens-in-Ledger-Live?docs=true

Is there anything else I can do to get this one through?

@gre gre merged commit de07f1c into LedgerHQ:develop May 27, 2024
24 checks passed
valpinkman added a commit that referenced this pull request May 28, 2024
@valpinkman
Merge branch 'develop' into support/hotfix-merge-conflicts
3ba9ca1 
* develop: (203 commits)
  ci: update workflow
  ci: fix
  ci: updtate e2e workflow
  🐛 : [BUGFIX] Layout issue with new Gainers/Losers trend widget if LLD is in French or German (#6932)
  Add basic tests
  Reorg files into new architecture folder
  ci: adding changeset
  ci: ENABLE_TRANSACTION_BROADCAST
  ci: e2e nightly - setup default value to variables
  feat(context-module): new module
  feat(eth): signature for setExternalPlugin is now optional
  [LIVE-9296] Feature - Use Ethereum app for all EVMs (#6861)
  support: add LL token icon (#6776)
  [LLD] - [LIVE-12264] - Add Wallet Sync activation screen (#6782)
  Add changeset
  Store components in several folder
  Initialize WalletSync Manage screen
  test(wallet-api): add test to avoid future regressions
  fix(platform): xrp family not present
  fix(live-12705): display the disabled swap button when the form is not valid
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gre gre gre approved these changes

Assignees

@shaynos shaynos

Labels
fork Pull request base branch comes from a fork. ui Has changes in the design system library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shaynos @gre