Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 : [BUGFIX] Layout issue with new Gainers/Losers trend widget if LLD is in French or German #6932

Merged
merged 3 commits into from
May 27, 2024
Merged

🐛 : [BUGFIX] Layout issue with new Gainers/Losers trend widget if LLD is in French or German #6932

merged 3 commits into from
May 27, 2024

Conversation

mcayuelas-ledger
Copy link
Contributor

@mcayuelas-ledger mcayuelas-ledger commented May 24, 2024 •
edited by jira bot
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

There was a Layout issue with new Gainers/Losers trend widget if LLD is in French or German

  • on Pills on Dashboard
  • on Widget on Selectors (Up/down)
Screen.Recording.2024-05-24.at.15.06.45.mov

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@mcayuelas-ledger mcayuelas-ledger requested a review from a team as a code owner May 24, 2024 13:19
@vercel Vercel
Copy link

vercel bot commented May 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview May 24, 2024 1:48pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview May 24, 2024 1:48pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 24, 2024 1:48pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 24, 2024 1:48pm
web-tools ⬜️ Ignored (Inspect) Visit Preview May 24, 2024 1:48pm

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label May 24, 2024
@mcayuelas-ledger mcayuelas-ledger changed the title Bugfix/market widget responsive 🐛 : [BUGFIX] Layout issue with new Gainers/Losers trend widget if LLD is in French or German May 24, 2024
KVNLS
KVNLS approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@KVNLS KVNLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcayuelas-ledger mcayuelas-ledger merged commit 03ecd46 into develop May 27, 2024
33 of 34 checks passed
@mcayuelas-ledger mcayuelas-ledger deleted the bugfix/market-widget-responsive branch May 27, 2024 14:45
valpinkman added a commit that referenced this pull request May 28, 2024
@valpinkman
Merge branch 'develop' into support/hotfix-merge-conflicts
3ba9ca1 
* develop: (203 commits)
  ci: update workflow
  ci: fix
  ci: updtate e2e workflow
  🐛 : [BUGFIX] Layout issue with new Gainers/Losers trend widget if LLD is in French or German (#6932)
  Add basic tests
  Reorg files into new architecture folder
  ci: adding changeset
  ci: ENABLE_TRANSACTION_BROADCAST
  ci: e2e nightly - setup default value to variables
  feat(context-module): new module
  feat(eth): signature for setExternalPlugin is now optional
  [LIVE-9296] Feature - Use Ethereum app for all EVMs (#6861)
  support: add LL token icon (#6776)
  [LLD] - [LIVE-12264] - Add Wallet Sync activation screen (#6782)
  Add changeset
  Store components in several folder
  Initialize WalletSync Manage screen
  test(wallet-api): add test to avoid future regressions
  fix(platform): xrp family not present
  fix(live-12705): display the disabled swap button when the form is not valid
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KVNLS KVNLS KVNLS approved these changes

Assignees

@mcayuelas-ledger mcayuelas-ledger

Labels
desktop Has changes in LLD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mcayuelas-ledger @KVNLS