Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIVE-9296] Feature - Use Ethereum app for all EVMs #6861

Merged
merged 4 commits into from
May 27, 2024

Conversation

lambertkevin
Copy link
Contributor

@lambertkevin lambertkevin commented May 15, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • New nano app used for Polygon, BSC & Ethereum Classic
    • Swap should still be working correctly (tested manually by the QA team)

📝 Description

Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bugfixes, you can explain the previous behavior and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented May 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2024 2:46pm
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview May 24, 2024 2:46pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview May 24, 2024 2:46pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 24, 2024 2:46pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 24, 2024 2:46pm

@live-github-bot live-github-bot bot added the ledgerjs Has changes in the ledgerjs open source libs label May 15, 2024
@ledger-wiz-cspm-secret-detection
Copy link

ledger-wiz-cspm-secret-detection bot commented May 15, 2024

Wiz Scan Summary

IaC Misconfigurations 0C 0H 0M 0L 0I
Sensitive Data 0C 0H 0M 2L 0I
Total 0C 0H 0M 2L 0I
Secrets 0🔑

@live-github-bot
Copy link
Contributor

live-github-bot bot commented May 15, 2024

Desktop Bundle Checks

Comparing 1e320d3 against 69a7d59.

⚠️ renderer bundle size significantly increased: 38.2mb -> 38.4mb. Please check if this is expected.

Mobile Bundle Checks

Comparing 1e320d3 against 0bb6b76.

⚠️ main.ios.jsbundle bundle size significantly increased: 58.7mb -> 58.8mb. Please check if this is expected.
⚠️ main.android.jsbundle bundle size significantly increased: 58.7mb -> 58.8mb. Please check if this is expected.

@lambertkevin lambertkevin force-pushed the feature/ethereum-app-for-all-evms branch from 398ea08 to 00d7527 Compare May 23, 2024 08:47
@lambertkevin lambertkevin changed the title [DRAFT] Feature - Use Ethereum app for all EVMs [LIVE-9296] Feature - Use Ethereum app for all EVMs May 23, 2024
@lambertkevin lambertkevin marked this pull request as ready for review May 23, 2024 08:54
@lambertkevin lambertkevin requested a review from a team as a code owner May 23, 2024 08:54
Copy link
Contributor

@sprohaszka-ledger sprohaszka-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hzheng-ledger
hzheng-ledger previously approved these changes May 24, 2024
Copy link
Contributor

@hzheng-ledger hzheng-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to me

@lambertkevin lambertkevin requested a review from a team as a code owner May 24, 2024 14:42
@live-github-bot live-github-bot bot added the common Has changes in live-common label May 24, 2024
@lambertkevin lambertkevin merged commit 84274a6 into develop May 27, 2024
66 of 69 checks passed
@lambertkevin lambertkevin deleted the feature/ethereum-app-for-all-evms branch May 27, 2024 10:18
valpinkman added a commit that referenced this pull request May 28, 2024
* develop: (203 commits)
  ci: update workflow
  ci: fix
  ci: updtate e2e workflow
  🐛 : [BUGFIX] Layout issue with new Gainers/Losers trend widget if LLD is in French or German (#6932)
  Add basic tests
  Reorg files into new architecture folder
  ci: adding changeset
  ci: ENABLE_TRANSACTION_BROADCAST
  ci: e2e nightly - setup default value to variables
  feat(context-module): new module
  feat(eth): signature for setExternalPlugin is now optional
  [LIVE-9296] Feature - Use Ethereum app for all EVMs (#6861)
  support: add LL token icon (#6776)
  [LLD] - [LIVE-12264] - Add Wallet Sync activation screen (#6782)
  Add changeset
  Store components in several folder
  Initialize WalletSync Manage screen
  test(wallet-api): add test to avoid future regressions
  fix(platform): xrp family not present
  fix(live-12705): display the disabled swap button when the form is not valid
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants