[LLD] - [LIVE-12264] - Add Wallet Sync activation screen #6782

sshmaxime · 2024-04-30T10:13:36Z

✅ Checklist

npx changeset was attached.
Covered by automatic tests.
Impact of the changes:
- ...

📝 Description

This PR adds the Wallet Sync activation screen on LLD.

Note: It is missing shadows on the icons.

❓ Context

JIRA or GitHub link: LIVE-12264

🧐 Checklist for the PR Reviewers

The code aligns with the requirements described in the linked JIRA or GitHub issue.
The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
There are no undocumented trade-offs, technical debt, or maintainability issues.
The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
Any new dependencies have been justified and documented.
Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

vercel · 2024-04-30T10:13:37Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments

Name	Status	Preview	Updated (UTC)
ledger-live-docs	⬜️ Ignored (Inspect)	Visit Preview	May 20, 2024 10:04am
ledger-live-github-bot	⬜️ Ignored (Inspect)	Visit Preview	May 20, 2024 10:04am
native-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview	May 20, 2024 10:04am
react-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview	May 20, 2024 10:04am
web-tools	⬜️ Ignored (Inspect)	Visit Preview	May 20, 2024 10:04am

apps/ledger-live-desktop/src/renderer/screens/settings/sections/General/WalletSyncRow.tsx

mcayuelas-ledger · 2024-04-30T15:32:56Z

On the ticket I don’t have a backup activated on instance, even if we don't have this already you can imagine a way to fake that with a store :)

KVNLS · 2024-04-30T16:19:32Z

More generally, I think that we should start to write our Integration tests now for Wallet Sync.
I would like to see a first test that could match the US we answer with this PR. Even if we partially answer the US we can incrementally update the integration test on each PR.

mcayuelas-ledger · 2024-05-14T14:04:35Z

...ger-live-desktop/src/renderer/screens/settings/sections/General/walletSync/WalletSyncRow.tsx


 const WalletSyncRow = () => {
-  const lldWalletSync = useFeature("lldWalletSync");
-
+  const walletSync = useSelector(walletSyncSelector);


you can create a selector for activated only, in order to not "export" all the state

Felt like it wasn't necessary right now.

KVNLS

Could you use the same file naming conventions for this folder, please?
PascalCase + index.tsx
WalletSync/index.tsx

KVNLS · 2024-05-14T15:29:40Z

apps/ledger-live-desktop/static/i18n/en/app.json

+      "cta": "Create a backup"
+    },
+    "alreadySync": {
+      "title": "Already created a back-up on another Device ?",


Suggested change

"title": "Already created a back-up on another Device ?",

"title": "Already created a back-up on another Device?",

KVNLS · 2024-05-14T15:32:48Z

...desktop/src/renderer/screens/settings/sections/General/walletSync/sideContent/Activation.tsx

+          <LogoWrapper>
+            <Icons.Refresh size="L" color={colors.constant.purple} />
+          </LogoWrapper>


This icon should not have 70% opacity.

KVNLS

LGTM!

* Add Activation screen for Wallet Sync * Add WalletSync store * Split WalletSync by Activaton & Manage side content * Add changeset * Add first test * fix lint * Fix test with translation --------- Co-authored-by: Martin Cayuelas <[email protected]>

* develop: (203 commits) ci: update workflow ci: fix ci: updtate e2e workflow 🐛 : [BUGFIX] Layout issue with new Gainers/Losers trend widget if LLD is in French or German (#6932) Add basic tests Reorg files into new architecture folder ci: adding changeset ci: ENABLE_TRANSACTION_BROADCAST ci: e2e nightly - setup default value to variables feat(context-module): new module feat(eth): signature for setExternalPlugin is now optional [LIVE-9296] Feature - Use Ethereum app for all EVMs (#6861) support: add LL token icon (#6776) [LLD] - [LIVE-12264] - Add Wallet Sync activation screen (#6782) Add changeset Store components in several folder Initialize WalletSync Manage screen test(wallet-api): add test to avoid future regressions fix(platform): xrp family not present fix(live-12705): display the disabled swap button when the form is not valid ...

github-actions bot assigned sshmaxime Apr 30, 2024

live-github-bot bot added desktop Has changes in LLD translations Translation files have been touched labels Apr 30, 2024

sshmaxime force-pushed the feat/LIVE-12264 branch from 29e5925 to 21a9128 Compare April 30, 2024 15:09

live-github-bot bot removed the translations Translation files have been touched label Apr 30, 2024

sshmaxime marked this pull request as ready for review April 30, 2024 15:11

sshmaxime requested a review from a team as a code owner April 30, 2024 15:11

KVNLS requested changes Apr 30, 2024

View reviewed changes

apps/ledger-live-desktop/src/renderer/screens/settings/sections/General/WalletSyncRow.tsx Outdated Show resolved Hide resolved

KVNLS requested changes Apr 30, 2024

View reviewed changes

apps/ledger-live-desktop/src/renderer/screens/settings/sections/General/WalletSyncRow.tsx Outdated Show resolved Hide resolved

mcayuelas-ledger requested changes Apr 30, 2024

View reviewed changes

sshmaxime force-pushed the feat/LIVE-12264 branch from 21a9128 to 443e92d Compare May 14, 2024 09:00

live-github-bot bot added the translations Translation files have been touched label May 14, 2024

sshmaxime requested review from mcayuelas-ledger and KVNLS May 14, 2024 09:43

mcayuelas-ledger reviewed May 14, 2024

View reviewed changes

KVNLS requested changes May 14, 2024

View reviewed changes

sshmaxime force-pushed the feat/LIVE-12264 branch 3 times, most recently from 285fe06 to 9343252 Compare May 15, 2024 08:50

sshmaxime requested review from mcayuelas-ledger and KVNLS May 15, 2024 09:00

sshmaxime force-pushed the feat/LIVE-12264 branch 2 times, most recently from 90d89f5 to 1c4baf8 Compare May 15, 2024 15:33

mcayuelas-ledger force-pushed the feat/LIVE-12264 branch from 1c4baf8 to 7930a6b Compare May 16, 2024 08:45

sshmaxime added 3 commits May 16, 2024 11:31

Add Activation screen for Wallet Sync

bdb8c0b

Add WalletSync store

3fe0094

Split WalletSync by Activaton & Manage side content

009350e

Add changeset

027ef52

sshmaxime force-pushed the feat/LIVE-12264 branch from 7930a6b to 027ef52 Compare May 16, 2024 09:31

Add first test

6e76a4e

mcayuelas-ledger requested a review from a team as a code owner May 17, 2024 15:36

mcayuelas-ledger added 2 commits May 20, 2024 10:16

fix lint

bbe0c30

Fix test with translation

a4882c4

KVNLS approved these changes May 20, 2024

View reviewed changes

mcayuelas-ledger merged commit 879fda4 into develop May 20, 2024
32 of 34 checks passed

mcayuelas-ledger deleted the feat/LIVE-12264 branch May 20, 2024 12:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[LLD] - [LIVE-12264] - Add Wallet Sync activation screen #6782

[LLD] - [LIVE-12264] - Add Wallet Sync activation screen #6782

sshmaxime commented Apr 30, 2024 •

edited by mcayuelas-ledger

Loading

vercel bot commented Apr 30, 2024 •

edited

Loading

mcayuelas-ledger commented Apr 30, 2024

KVNLS commented Apr 30, 2024

mcayuelas-ledger May 14, 2024

sshmaxime May 15, 2024

KVNLS left a comment

KVNLS May 14, 2024

KVNLS May 14, 2024

KVNLS left a comment

	"title": "Already created a back-up on another Device ?",
	"title": "Already created a back-up on another Device?",

[LLD] - [LIVE-12264] - Add Wallet Sync activation screen #6782

[LLD] - [LIVE-12264] - Add Wallet Sync activation screen #6782

Conversation

sshmaxime commented Apr 30, 2024 • edited by mcayuelas-ledger Loading

✅ Checklist

📝 Description

❓ Context

🧐 Checklist for the PR Reviewers

vercel bot commented Apr 30, 2024 • edited Loading

mcayuelas-ledger commented Apr 30, 2024

KVNLS commented Apr 30, 2024

mcayuelas-ledger May 14, 2024

Choose a reason for hiding this comment

sshmaxime May 15, 2024

Choose a reason for hiding this comment

KVNLS left a comment

Choose a reason for hiding this comment

KVNLS May 14, 2024

Choose a reason for hiding this comment

KVNLS May 14, 2024

Choose a reason for hiding this comment

KVNLS left a comment

Choose a reason for hiding this comment

sshmaxime commented Apr 30, 2024 •

edited by mcayuelas-ledger

Loading

vercel bot commented Apr 30, 2024 •

edited

Loading