VPN uninstall not stopping agent in App Store build #2999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
diegoreymendez
requested review from
quanganhdo
and removed request for
samsymons
quanganhdo
approved these changes
Jun 27, 2024
diegoreymendez
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Jun 27, 2024
… wouldn't quit (#866) Task/Issue URL: https://app.asana.com/0/1207603085593419/1207659744300515/f iOS PR: duckduckgo/iOS#2999 macOS PR: duckduckgo/macos-browser#2911 What kind of version bump will this require?: Major/Minor/Patch ## Description Fixes stopping the VPN agent after uninstalling the VPN in App Store builds.
github-actions
bot
added
the
bot: not in app board
diegoreymendez
removed
the
bot: not in app board
diegoreymendez
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Jun 27, 2024
Task/Issue URL: https://app.asana.com/0/1207603085593419/1207659744300515/f iOS PR: duckduckgo/iOS#2999 BSK PR: duckduckgo/BrowserServicesKit#866 ## Description Fixes stopping the VPN agent after uninstalling the VPN in App Store builds.
samsymons
added a commit
that referenced
this pull request
Jun 28, 2024
…ess-token # By Diego Rey Mendez (1) and bwaresiak (1) # Via GitHub * main: In case Pending Deletion flag is nil, populate it with 'false' value (#2997) VPN uninstall not stopping agent in App Store build (#2999) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
that referenced
this pull request
Jul 1, 2024
* main: Fire a pixel when removing the VPN configuration (#3014) Release 7.127.0-0 (#3020) point to BSK branch (#3016) [DuckPlayer] - 3. URL management & FE comms (#3007) Bump BSK version (#3011) New Tab Page layout and base elements (#3008) Remove Privacy Pro from device once expired account is deleted (#3009) Improvements to subscription settings (#2959) Toggle reports limiter (#3005) Duck Player info Modal (#3006) Silence tunnel startup noise with no access token available (#2993) In case Pending Deletion flag is nil, populate it with 'false' value (#2997) VPN uninstall not stopping agent in App Store build (#2999) Update VPN metadata to include entitlement (#3002)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1207603085593419/1207659744300515/f
macOS PR: duckduckgo/macos-browser#2911
BSK PR: duckduckgo/BrowserServicesKit#866
Description
These changes are macOS specific, so we're just updating BSK to include the latest changes.
Testing
Just make sure the VPN works as always.
Internal references:
Software Engineering Expectations
Technical Design Template