Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VPN metadata to include entitlement #3002

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

samsymons
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/414235014887631/1207672846964315/f
Tech Design URL:
CC:

Description:

This PR updates the metadata collector to include entitlement status.

Steps to test this PR:

  1. Sign into a Privacy Pro account
  2. Go the Network Protection debug screen, and check the metadata at the bottom to ensure it prints true for both account and entitlement status

Definition of Done (Internal Only):

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@samsymons samsymons merged commit 9ce5afe into main Jun 27, 2024
18 checks passed
@samsymons samsymons deleted the sam/vpn-metadata-report-entitlement-status branch June 27, 2024 03:32
samsymons added a commit that referenced this pull request Jun 27, 2024
…ess-token

# By Christopher Brind (3) and others
# Via Chris Brind (1) and GitHub (1)
* main:
  Update VPN metadata to include entitlement (#3002)
  Remove noise from wake pixel (#2986)
  Release 7.126.0-1 (#2998)
  [DuckPlayer] - 2. Overlay Views (#2989)
  update translations for autocomplete settings changes (#2995)
  Fixes goBack() behavior (#2996)
  Re-add the autocomplete settings toggle pixels (#2991)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons added a commit that referenced this pull request Jul 1, 2024
* main:
  Fire a pixel when removing the VPN configuration (#3014)
  Release 7.127.0-0 (#3020)
  point to BSK branch (#3016)
  [DuckPlayer] - 3. URL management & FE comms (#3007)
  Bump BSK version (#3011)
  New Tab Page layout and base elements (#3008)
  Remove Privacy Pro from device once expired account is deleted (#3009)
  Improvements to subscription settings (#2959)
  Toggle reports limiter (#3005)
  Duck Player info Modal (#3006)
  Silence tunnel startup noise with no access token available (#2993)
  In case Pending Deletion flag is nil, populate it with 'false' value (#2997)
  VPN uninstall not stopping agent in App Store build (#2999)
  Update VPN metadata to include entitlement (#3002)
samsymons added a commit that referenced this pull request Jul 4, 2024
* main:
  Update VPN metadata to include entitlement (#3002)
  Remove noise from wake pixel (#2986)
  Release 7.126.0-1 (#2998)
  [DuckPlayer] - 2. Overlay Views (#2989)
  update translations for autocomplete settings changes (#2995)
  Fixes goBack() behavior (#2996)
  Re-add the autocomplete settings toggle pixels (#2991)
  Update BSK with autofill 12.0.1 (#2983)
  Final batch of new autofill pixels (#2977)
  don't attach a new home screen if autoclear is in progress (#2988)
  Custom DNS for VPN (#2971)
  Duck Player settings page (#2990)
  Add feature flag for improved New Tab Page  (#2980)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants