Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update translations for autocomplete settings changes #2995

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

brindy
Copy link
Contributor

@brindy brindy commented Jun 26, 2024

Task/Issue URL: https://app.asana.com/0/392891325557410/1207665527674202/f
Tech Design URL:
CC:

Description:
Applies translations

Steps to test this PR:

  1. Run the app in England another couple of locales.
  2. Validate that translations have been applied to autocomplete settings (Private Search and General)
  3. Edit HisoryMessageManager and set shouldShow to return true
  4. Type in the search field
  5. Validate the translation has been applied to the message

@brindy brindy requested a review from dus7 June 26, 2024 11:44
dus7
dus7 previously approved these changes Jun 26, 2024
@dus7 dus7 dismissed their stale review June 26, 2024 12:22

Missclick

@brindy brindy merged commit c899846 into release/7.126.0 Jun 26, 2024
18 checks passed
@brindy brindy deleted the brindy/update-autocomplete-copy branch June 26, 2024 12:31
samsymons added a commit that referenced this pull request Jun 27, 2024
…ess-token

# By Christopher Brind (3) and others
# Via Chris Brind (1) and GitHub (1)
* main:
  Update VPN metadata to include entitlement (#3002)
  Remove noise from wake pixel (#2986)
  Release 7.126.0-1 (#2998)
  [DuckPlayer] - 2. Overlay Views (#2989)
  update translations for autocomplete settings changes (#2995)
  Fixes goBack() behavior (#2996)
  Re-add the autocomplete settings toggle pixels (#2991)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons added a commit that referenced this pull request Jul 4, 2024
* main:
  Update VPN metadata to include entitlement (#3002)
  Remove noise from wake pixel (#2986)
  Release 7.126.0-1 (#2998)
  [DuckPlayer] - 2. Overlay Views (#2989)
  update translations for autocomplete settings changes (#2995)
  Fixes goBack() behavior (#2996)
  Re-add the autocomplete settings toggle pixels (#2991)
  Update BSK with autofill 12.0.1 (#2983)
  Final batch of new autofill pixels (#2977)
  don't attach a new home screen if autoclear is in progress (#2988)
  Custom DNS for VPN (#2971)
  Duck Player settings page (#2990)
  Add feature flag for improved New Tab Page  (#2980)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants