Duck Player settings page #2990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bot: not in app board
github-actions
bot
removed
the
bot: not in app board
afterxleep
approved these changes
Jun 25, 2024
🎉
samsymons
added a commit
that referenced
this pull request
Jul 4, 2024
* main: Update VPN metadata to include entitlement (#3002) Remove noise from wake pixel (#2986) Release 7.126.0-1 (#2998) [DuckPlayer] - 2. Overlay Views (#2989) update translations for autocomplete settings changes (#2995) Fixes goBack() behavior (#2996) Re-add the autocomplete settings toggle pixels (#2991) Update BSK with autofill 12.0.1 (#2983) Final batch of new autofill pixels (#2977) don't attach a new home screen if autoclear is in progress (#2988) Custom DNS for VPN (#2971) Duck Player settings page (#2990) Add feature flag for improved New Tab Page (#2980)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1201011656765697/1207610368803725/f
Tech Design URL:
CC:
Description:
Add UI for Duck Player settings page
Note: This PR does not changes the issue with the 3 options "always" in the settings
Steps to test this PR: