Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't attach a new home screen if autoclear is in progress #2988

Merged
merged 1 commit into from
Jun 25, 2024
Merged

don't attach a new home screen if autoclear is in progress #2988

merged 1 commit into from
Jun 25, 2024

Conversation

brindy
Copy link
Contributor

@brindy brindy commented Jun 25, 2024

Task/Issue URL: https://app.asana.com/0/392891325557410/1207536057103452/f
Tech Design URL:
CC:

Description:
With auto clear enabled the Home Screen is attached twice.

Steps to test this PR:

  1. Enable to autoclear.
  2. Load some pages.
  3. Kill the app and restart it.
  4. mh pixel should only be fired once.
  5. Repeat above with autoclear expiry
  6. Turn off autoclear
  7. Load some pages
  8. Background the app and wait 30 seconds
  9. Foreground the app, make sure app state is as expected
  10. Kill the app and relaunch, make sure app state is expected
  11. Retest with no pages loaded. mh should only fire once.

@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Jun 25, 2024
@brindy brindy requested a review from bwaresiak June 25, 2024 04:40
@github-actions github-actions bot removed the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Jun 25, 2024
bwaresiak
bwaresiak approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@bwaresiak bwaresiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested this on both iPhone and iPad.

@brindy brindy merged commit 127758b into main Jun 25, 2024
17 of 18 checks passed
@brindy brindy deleted the brindy/reduce-duplicate-mh-pixels branch June 25, 2024 17:32
samsymons added a commit that referenced this pull request Jul 4, 2024
@samsymons
Merge branch 'main' into sam/vpn-snooze-initial-support
5bb79dc 
* main:
  Update VPN metadata to include entitlement (#3002)
  Remove noise from wake pixel (#2986)
  Release 7.126.0-1 (#2998)
  [DuckPlayer] - 2. Overlay Views (#2989)
  update translations for autocomplete settings changes (#2995)
  Fixes goBack() behavior (#2996)
  Re-add the autocomplete settings toggle pixels (#2991)
  Update BSK with autofill 12.0.1 (#2983)
  Final batch of new autofill pixels (#2977)
  don't attach a new home screen if autoclear is in progress (#2988)
  Custom DNS for VPN (#2971)
  Duck Player settings page (#2990)
  Add feature flag for improved New Tab Page  (#2980)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwaresiak bwaresiak bwaresiak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brindy @bwaresiak