Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final batch of new autofill pixels #2977

Merged
merged 10 commits into from
Jun 25, 2024
Merged

Conversation

amddg44
Copy link
Contributor

@amddg44 amddg44 commented Jun 20, 2024

Task/Issue URL: https://app.asana.com/0/1203822806345703/1207602891714014/f
Tech Design URL:
CC:

Description:
Final autofill pixels implemented (mostly related to credential management in the UI)

Steps to test this PR:

  1. In XCode console log, filter for m.autofill.management
  2. Launch the app and access the Passwords screen via the tab bar ... menu
  3. Confirm the pixel m.autofill.management.opened fires with parameter ["source": "overflow_menu"]
  4. In the passwords screen create a new login with any username & password
  5. Confirm the pixel m.autofill.management.save.login is fired
  6. Edit and save the login
  7. Confirm the pixel m.autofill.management.update.login is fired
  8. Tap the copy button next the username
  9. Confirm the pixel m.autofill.management.copy.username is fired
  10. Tap the copy button next the password
  11. Confirm the pixel m.autofill.management.copy.password is fired
  12. From the same screen delete the login
  13. Confirm the pixel m.autofill.management.delete.login is fired (once the delete undo toast disappears)
  14. Create another new login (if you don't have any saved) and go back to the Passwords screen
  15. Tap the menu button from the navigation bar and select Edit
  16. Delete a single row
  17. Confirm the pixel m.autofill.management.delete.login is fired (once the delete undo toast disappears)
  18. Create another new login (if have none saved)
  19. Tap the menu button from the navigation bar and select Edit
  20. Tap Delete All from the toolbar
  21. Confirm the pixel m.autofill.management.delete.all.logins is fired (once the delete all undo toast disappears)
  22. Back out of the Passwords screen and come back in via the Settings screen
  23. Confirm the pixel m.autofill.management.opened fires with parameter ["source": "settings"]
  24. Minimise the app, long press on the app icon and select Search Password
  25. Confirm the pixel m.autofill.management.opened fires with parameter ["source": "app_icon_shortcut"]
  26. Add the Search Passwords home screen widget and tap it
  27. Confirm the pixel m.autofill.management.opened fires with parameter ["source": "home_screen_widget"]
  28. Add the Search Passwords lcok screen widget and tap it
  29. Confirm the pixel m.autofill.management.opened fires with parameter ["source": "lock_screen_widget"]

Internal references:

Software Engineering Expectations
Technical Design Template

…rds-pixels

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
@amddg44 amddg44 requested a review from graeme June 21, 2024 09:32
amddg44 added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Jun 25, 2024
Task/Issue URL: https://app.asana.com/0/1203822806345703/1207602891714015/f
iOS PR: duckduckgo/iOS#2977
macOS PR: duckduckgo/macos-browser#2881
What kind of version bump will this require?: Minor

Description:
Identities stacked pixel added
…rds-pixels

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
@amddg44 amddg44 merged commit 81f2dfc into main Jun 25, 2024
14 checks passed
@amddg44 amddg44 deleted the anya/remaining-passwords-pixels branch June 25, 2024 21:24
samsymons added a commit that referenced this pull request Jul 4, 2024
* main:
  Update VPN metadata to include entitlement (#3002)
  Remove noise from wake pixel (#2986)
  Release 7.126.0-1 (#2998)
  [DuckPlayer] - 2. Overlay Views (#2989)
  update translations for autocomplete settings changes (#2995)
  Fixes goBack() behavior (#2996)
  Re-add the autocomplete settings toggle pixels (#2991)
  Update BSK with autofill 12.0.1 (#2983)
  Final batch of new autofill pixels (#2977)
  don't attach a new home screen if autoclear is in progress (#2988)
  Custom DNS for VPN (#2971)
  Duck Player settings page (#2990)
  Add feature flag for improved New Tab Page  (#2980)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants