-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Final batch of new autofill pixels #2977
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rds-pixels # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
graeme
approved these changes
Jun 21, 2024
amddg44
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Jun 25, 2024
Task/Issue URL: https://app.asana.com/0/1203822806345703/1207602891714015/f iOS PR: duckduckgo/iOS#2977 macOS PR: duckduckgo/macos-browser#2881 What kind of version bump will this require?: Minor Description: Identities stacked pixel added
…rds-pixels # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
that referenced
this pull request
Jul 4, 2024
* main: Update VPN metadata to include entitlement (#3002) Remove noise from wake pixel (#2986) Release 7.126.0-1 (#2998) [DuckPlayer] - 2. Overlay Views (#2989) update translations for autocomplete settings changes (#2995) Fixes goBack() behavior (#2996) Re-add the autocomplete settings toggle pixels (#2991) Update BSK with autofill 12.0.1 (#2983) Final batch of new autofill pixels (#2977) don't attach a new home screen if autoclear is in progress (#2988) Custom DNS for VPN (#2971) Duck Player settings page (#2990) Add feature flag for improved New Tab Page (#2980)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1203822806345703/1207602891714014/f
Tech Design URL:
CC:
Description:
Final autofill pixels implemented (mostly related to credential management in the UI)
Steps to test this PR:
m.autofill.management
m.autofill.management.opened
fires with parameter["source": "overflow_menu"]
m.autofill.management.save.login
is firedm.autofill.management.update.login
is firedm.autofill.management.copy.username
is firedm.autofill.management.copy.password
is firedm.autofill.management.delete.login
is fired (once the delete undo toast disappears)Edit
m.autofill.management.delete.login
is fired (once the delete undo toast disappears)Edit
Delete All
from the toolbarm.autofill.management.delete.all.logins
is fired (once the delete all undo toast disappears)m.autofill.management.opened
fires with parameter["source": "settings"]
Search Password
m.autofill.management.opened
fires with parameter["source": "app_icon_shortcut"]
Search Passwords
home screen widget and tap itm.autofill.management.opened
fires with parameter["source": "home_screen_widget"]
Search Passwords
lcok screen widget and tap itm.autofill.management.opened
fires with parameter["source": "lock_screen_widget"]
Internal references:
Software Engineering Expectations
Technical Design Template