-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DuckPlayer] - 2. Overlay Views #2989
Conversation
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
# Conflicts: # Core/UserDefaultsPropertyWrapper.swift # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # DuckDuckGo/SettingsViewModel.swift
…ckplayer/2.overlay
# Conflicts: # Core/UserDefaultsPropertyWrapper.swift # DuckDuckGo/AppSettings.swift # DuckDuckGo/AppUserDefaults.swift # DuckDuckGo/DuckPlayer/DuckPlayer.swift # DuckDuckGo/DuckPlayer/YoutubeOverlayUserScript.swift # DuckDuckGo/DuckPlayer/YoutubePlayerUserScript.swift # DuckDuckGo/TabViewController.swift # DuckDuckGo/UserScripts.swift # DuckDuckGo/UserText.swift # DuckDuckGo/en.lproj/Localizable.strings # DuckDuckGoTests/AppSettingsMock.swift
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I've seen some issues I'll describe bellow, but not sure if it's part of this PR to solve them so I'm approving and letting you decide.
1. Bad text wrapping.
I believe this is expected since we're using the macOS page. But worth mentioning
2. Issue reloading
When reloading a video from duck player, instead of opening duck player again, it goes to the no-cookies URL
@Bunn Yes, both issues reported are expected. First is macOS UI related, correct. Second will be fixed by next PR (which takes care of the URL management). |
4ccebd7
to
cd86b19
Compare
…ess-token # By Christopher Brind (3) and others # Via Chris Brind (1) and GitHub (1) * main: Update VPN metadata to include entitlement (#3002) Remove noise from wake pixel (#2986) Release 7.126.0-1 (#2998) [DuckPlayer] - 2. Overlay Views (#2989) update translations for autocomplete settings changes (#2995) Fixes goBack() behavior (#2996) Re-add the autocomplete settings toggle pixels (#2991) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
* main: Update VPN metadata to include entitlement (#3002) Remove noise from wake pixel (#2986) Release 7.126.0-1 (#2998) [DuckPlayer] - 2. Overlay Views (#2989) update translations for autocomplete settings changes (#2995) Fixes goBack() behavior (#2996) Re-add the autocomplete settings toggle pixels (#2991) Update BSK with autofill 12.0.1 (#2983) Final batch of new autofill pixels (#2977) don't attach a new home screen if autoclear is in progress (#2988) Custom DNS for VPN (#2971) Duck Player settings page (#2990) Add feature flag for improved New Tab Page (#2980)
Task/Issue URL: https://app.asana.com/0/1204099484721401/1207650110399906/f
Description:
ℹ️ Known issue: The FE is sometimes starting navigation instead of pushing a WKMessage, which causes you to have double tap the "Watch in DuckPlayer" button sometimes. This is reported and should be fixed as part of the FE work
Steps to test this PR: