[DuckPlayer] - 2. Overlay Views #2989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
# Conflicts: # Core/UserDefaultsPropertyWrapper.swift # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # DuckDuckGo/SettingsViewModel.swift
…ckplayer/2.overlay
# Conflicts: # Core/UserDefaultsPropertyWrapper.swift # DuckDuckGo/AppSettings.swift # DuckDuckGo/AppUserDefaults.swift # DuckDuckGo/DuckPlayer/DuckPlayer.swift # DuckDuckGo/DuckPlayer/YoutubeOverlayUserScript.swift # DuckDuckGo/DuckPlayer/YoutubePlayerUserScript.swift # DuckDuckGo/TabViewController.swift # DuckDuckGo/UserScripts.swift # DuckDuckGo/UserText.swift # DuckDuckGo/en.lproj/Localizable.strings # DuckDuckGoTests/AppSettingsMock.swift
Bunn
reviewed
Jun 26, 2024
Bunn
reviewed
Jun 26, 2024
Bunn
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
LGTM. I've seen some issues I'll describe bellow, but not sure if it's part of this PR to solve them so I'm approving and letting you decide.
1. Bad text wrapping.
I believe this is expected since we're using the macOS page. But worth mentioning
2. Issue reloading
When reloading a video from duck player, instead of opening duck player again, it goes to the no-cookies URL
|
@Bunn Yes, both issues reported are expected. First is macOS UI related, correct. Second will be fixed by next PR (which takes care of the URL management). |
afterxleep
force-pushed
the
daniel/duckplayer/2.overlay
branch
from
4ccebd7
to
cd86b19
Compare
samsymons
added a commit
that referenced
this pull request
Jun 27, 2024
…ess-token # By Christopher Brind (3) and others # Via Chris Brind (1) and GitHub (1) * main: Update VPN metadata to include entitlement (#3002) Remove noise from wake pixel (#2986) Release 7.126.0-1 (#2998) [DuckPlayer] - 2. Overlay Views (#2989) update translations for autocomplete settings changes (#2995) Fixes goBack() behavior (#2996) Re-add the autocomplete settings toggle pixels (#2991) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
that referenced
this pull request
Jul 4, 2024
* main: Update VPN metadata to include entitlement (#3002) Remove noise from wake pixel (#2986) Release 7.126.0-1 (#2998) [DuckPlayer] - 2. Overlay Views (#2989) update translations for autocomplete settings changes (#2995) Fixes goBack() behavior (#2996) Re-add the autocomplete settings toggle pixels (#2991) Update BSK with autofill 12.0.1 (#2983) Final batch of new autofill pixels (#2977) don't attach a new home screen if autoclear is in progress (#2988) Custom DNS for VPN (#2971) Duck Player settings page (#2990) Add feature flag for improved New Tab Page (#2980)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1204099484721401/1207650110399906/f
Description:
ℹ️ Known issue: The FE is sometimes starting navigation instead of pushing a WKMessage, which causes you to have double tap the "Watch in DuckPlayer" button sometimes. This is reported and should be fixed as part of the FE work
Steps to test this PR: