Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add the autocomplete settings toggle pixels #2991

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

brindy
Copy link
Contributor

@brindy brindy commented Jun 25, 2024

Task/Issue URL: https://app.asana.com/0/414235014887631/1207656851886242/f
Tech Design URL:
CC:

Description:
Re-add the autocomplete settings toggle pixels which were removed accidentally during a clean up.

Steps to test this PR:

  1. Go to settings
  2. Toggle autocomplete on and off in general
  3. Toggle autocomplete on and off in private search
  4. Ensure correct pixel is fired for each state

@brindy brindy requested a review from dus7 June 25, 2024 17:24
Copy link
Contributor

@dus7 dus7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍. Verified pixels are sent.

@brindy brindy merged commit d460b80 into release/7.126.0 Jun 26, 2024
14 checks passed
@brindy brindy deleted the brindy/re-add-autocomplete-pixel branch June 26, 2024 09:42
samsymons added a commit that referenced this pull request Jun 27, 2024
…ess-token

# By Christopher Brind (3) and others
# Via Chris Brind (1) and GitHub (1)
* main:
  Update VPN metadata to include entitlement (#3002)
  Remove noise from wake pixel (#2986)
  Release 7.126.0-1 (#2998)
  [DuckPlayer] - 2. Overlay Views (#2989)
  update translations for autocomplete settings changes (#2995)
  Fixes goBack() behavior (#2996)
  Re-add the autocomplete settings toggle pixels (#2991)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons added a commit that referenced this pull request Jul 4, 2024
* main:
  Update VPN metadata to include entitlement (#3002)
  Remove noise from wake pixel (#2986)
  Release 7.126.0-1 (#2998)
  [DuckPlayer] - 2. Overlay Views (#2989)
  update translations for autocomplete settings changes (#2995)
  Fixes goBack() behavior (#2996)
  Re-add the autocomplete settings toggle pixels (#2991)
  Update BSK with autofill 12.0.1 (#2983)
  Final batch of new autofill pixels (#2977)
  don't attach a new home screen if autoclear is in progress (#2988)
  Custom DNS for VPN (#2971)
  Duck Player settings page (#2990)
  Add feature flag for improved New Tab Page  (#2980)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants