Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle reports limiter #3005

Merged
merged 7 commits into from
Jun 28, 2024
Merged

Toggle reports limiter #3005

merged 7 commits into from
Jun 28, 2024

Conversation

jaceklyp
Copy link
Contributor

@jaceklyp jaceklyp commented Jun 27, 2024

Task/Issue URL: https://app.asana.com/0/1163321984198618/1207430232012866/f

Description:
Implement logic to limit the number of times users see the opt-in prompts for simplified toggle reports to reduce potential annoyance.

Steps to test this PR:
See: https://app.asana.com/0/1163321984198618/1207669104671010/f
Use this config: https://jsonblob.com/api/1255547168315269120

Definition of Done (Internal Only):

@jaceklyp jaceklyp requested a review from ayoy June 28, 2024 11:15
Copy link
Contributor

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Jun 28, 2024
@jaceklyp jaceklyp removed the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Jun 28, 2024
@jaceklyp jaceklyp merged commit 4e559d6 into main Jun 28, 2024
24 of 26 checks passed
@jaceklyp jaceklyp deleted the jacek/toggle-reports-limiter branch June 28, 2024 14:38
samsymons added a commit that referenced this pull request Jul 1, 2024
* main:
  Fire a pixel when removing the VPN configuration (#3014)
  Release 7.127.0-0 (#3020)
  point to BSK branch (#3016)
  [DuckPlayer] - 3. URL management & FE comms (#3007)
  Bump BSK version (#3011)
  New Tab Page layout and base elements (#3008)
  Remove Privacy Pro from device once expired account is deleted (#3009)
  Improvements to subscription settings (#2959)
  Toggle reports limiter (#3005)
  Duck Player info Modal (#3006)
  Silence tunnel startup noise with no access token available (#2993)
  In case Pending Deletion flag is nil, populate it with 'false' value (#2997)
  VPN uninstall not stopping agent in App Store build (#2999)
  Update VPN metadata to include entitlement (#3002)
samsymons added a commit that referenced this pull request Jul 4, 2024
* main: (24 commits)
  Add pixels to measure baseline for New Tab Page sections (#3024)
  backgrounding UI tests (#3021)
  improve bookmarks and favorites UI tests (#3019)
  [DuckPlayer] - 4. Remote Config (#3018)
  Updates BSK
  Fix issue when cancelling a download (#3030)
  Tentative fix for a crash and connectivity issues (#3027)
  autofill UI tests (#3012)
  scripts for running UI tests (#3000)
  Integrate RemoteMessaging with NewTabPage (#3017)
  Update to iOS 15 deployment target (#3001)
  Fire a pixel when removing the VPN configuration (#3014)
  Release 7.127.0-0 (#3020)
  point to BSK branch (#3016)
  [DuckPlayer] - 3. URL management & FE comms (#3007)
  Bump BSK version (#3011)
  New Tab Page layout and base elements (#3008)
  Remove Privacy Pro from device once expired account is deleted (#3009)
  Improvements to subscription settings (#2959)
  Toggle reports limiter (#3005)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants