-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scripts for running UI tests #3000
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loremattei
reviewed
Jun 27, 2024
@loremattei addressed your comments - ready for another look, thanks. |
loremattei
reviewed
Jun 27, 2024
loremattei
reviewed
Jun 28, 2024
Just pushed a few changes
|
Merged
loremattei
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brindy this looks great!
Thanks for all the updates!
brindy
added a commit
that referenced
this pull request
Jul 3, 2024
Task/Issue URL: https://app.asana.com/0/392891325557410/1207203028528351/f Tech Design URL: CC: @loremattei @bwaresiak Description: Tests Autofill scenarios: Password management (add, edit, delete, search, etc) Password autofill (standard login, multi-step login) Password authentication (ensure device auth is shown in various scenarios) Notes: The scripts are being reviewed in scripts for running UI tests #3000 so you can largely ignore them. You should be able to run the scripts from anywhere, just adjust the paths below accordingly Steps to test this PR: Confirm End to End tests have passed: https://github.com/duckduckgo/iOS/actions/runs/9726361554/job/26844719247 In terminal cd into .maestro Run setup_ui_tests.sh Optional: run all the release tests in one go using: run_tests_tests.sh release_tests Run run_ui_tests.sh release_tests/password-autofill.yaml Run run_ui_tests.sh release_tests/password-authentication.yaml Run run_ui_tests.sh release_tests/password-management.yaml
brindy
added a commit
that referenced
this pull request
Jul 3, 2024
Task/Issue URL: https://app.asana.com/0/392891325557410/1207195241923822/f Tech Design URL: CC: @bwaresiak Description: Fleshed out and tweaked bookmarks and favorites UI tests Notes: The scripts are being reviewed in scripts for running UI tests #3000 so you can largely ignore them. You should be able to run the scripts from anywhere, just adjust the paths below accordingly Fixes a bug found during testing in the bookmarks swift code Steps to test this PR: Confirm End to End tests have passed: https://github.com/duckduckgo/iOS/actions/runs/9750711656 In terminal cd into .maestro Run setup_ui_tests.sh Optional: run all the release tests in one go using: run_tests_tests.sh release_tests Run run_ui_tests.sh release_tests/bookmarks.yaml Run run_ui_tests.sh release_tests/bookmarks-multi.yaml Run run_ui_tests.sh release_tests/favorites.yaml
samsymons
added a commit
that referenced
this pull request
Jul 4, 2024
* main: (24 commits) Add pixels to measure baseline for New Tab Page sections (#3024) backgrounding UI tests (#3021) improve bookmarks and favorites UI tests (#3019) [DuckPlayer] - 4. Remote Config (#3018) Updates BSK Fix issue when cancelling a download (#3030) Tentative fix for a crash and connectivity issues (#3027) autofill UI tests (#3012) scripts for running UI tests (#3000) Integrate RemoteMessaging with NewTabPage (#3017) Update to iOS 15 deployment target (#3001) Fire a pixel when removing the VPN configuration (#3014) Release 7.127.0-0 (#3020) point to BSK branch (#3016) [DuckPlayer] - 3. URL management & FE comms (#3007) Bump BSK version (#3011) New Tab Page layout and base elements (#3008) Remove Privacy Pro from device once expired account is deleted (#3009) Improvements to subscription settings (#2959) Toggle reports limiter (#3005) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/392891325557410/1207589761442405/f
Tech Design URL:
CC: @bwaresiak
Description:
Adds scripts for running the UI tests locally in a way that's similar to how they run on CI.
Setting up UI tests:
.maestro/setup_ui_tests.sh
from the.maestro
folder. It should tell you to run it from the root. If there are other errors with your environment (such as missing commands) it will also fail..maestro/setup_ui_tests.sh
from the root. It'll build the app to a localDerivedData
folder, create a simulator and install the app.maestro/setup_ui_tests.sh --skip-build
. It'll skip the build, but create a simulator and install the app if one is available in the right locationRunning UI tests:
.maestro/run_ui_tests.sh
. It'll fail because you need to specific a location for the flow files to run..maestro/run_ui_tests.sh --flow-location .maestro\x
which will fail because the location is wrong..maestro/run_ui_tests.sh --flow-location .maestro\release_tests\
it will run the tests and create a file called run_log.txt inDerivedData
. Once it finishes it'll dump that file to the console. If they all passed it will show a success message..maestro/run_ui_tests.sh --run-flow
it'll fail because you need to specify a flow file.maestro/run_ui_tests.sh --run-flow .maestro/release_tests/bookmarks.yaml
it'll run just that test.maestro/run_ui_tests.sh --flow-location .maestro\release_tests\
and hit Ctrl-C. This will make it appear like the test has failed. Do this for a few test and allow others to pass. The final message should indicate that some failures occurred.Cleaning up:
.maestro/clean_simulators.sh
and it'll kill the simulators and then remove the ones that have 'maestro' in the name. Some errors might get printed for where they don't need to be shutdown but this can be ignored.