New Tab Page layout and base elements #3008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bot: not in app board
dus7
removed
the
bot: not in app board
brindy
approved these changes
Jun 29, 2024
DuckDuckGo/FavoritesView.swift
Outdated
| } | ||
|
|
||
| private func emptyIcon() -> Image { | ||
| Image(systemName: "square.grid.3x3.middle.filled") |
There was a problem hiding this comment.
This is temporary - wanted to have anything other than blank view displayed. I'll remove that when integrating favorites.
Decided to remove it right now. Since there is a shadow and white background items are visible without an icon.
| struct NewTabPageCustomizeButtonView: View { | ||
| var body: some View { | ||
| HStack { | ||
| Image(.options16) |
There was a problem hiding this comment.
Yes. These are autogenerated asset symbols.
Yes, in fact it should be even bigger - there was a change on designs. I'll adjust that. |
Use proper empty state view for favorites
samsymons
added a commit
that referenced
this pull request
Jul 1, 2024
* main: Fire a pixel when removing the VPN configuration (#3014) Release 7.127.0-0 (#3020) point to BSK branch (#3016) [DuckPlayer] - 3. URL management & FE comms (#3007) Bump BSK version (#3011) New Tab Page layout and base elements (#3008) Remove Privacy Pro from device once expired account is deleted (#3009) Improvements to subscription settings (#2959) Toggle reports limiter (#3005) Duck Player info Modal (#3006) Silence tunnel startup noise with no access token available (#2993) In case Pending Deletion flag is nil, populate it with 'false' value (#2997) VPN uninstall not stopping agent in App Store build (#2999) Update VPN metadata to include entitlement (#3002)
samsymons
added a commit
that referenced
this pull request
Jul 4, 2024
* main: (24 commits) Add pixels to measure baseline for New Tab Page sections (#3024) backgrounding UI tests (#3021) improve bookmarks and favorites UI tests (#3019) [DuckPlayer] - 4. Remote Config (#3018) Updates BSK Fix issue when cancelling a download (#3030) Tentative fix for a crash and connectivity issues (#3027) autofill UI tests (#3012) scripts for running UI tests (#3000) Integrate RemoteMessaging with NewTabPage (#3017) Update to iOS 15 deployment target (#3001) Fire a pixel when removing the VPN configuration (#3014) Release 7.127.0-0 (#3020) point to BSK branch (#3016) [DuckPlayer] - 3. URL management & FE comms (#3007) Bump BSK version (#3011) New Tab Page layout and base elements (#3008) Remove Privacy Pro from device once expired account is deleted (#3009) Improvements to subscription settings (#2959) Toggle reports limiter (#3005) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1206226850447395/1207685167967158/f
Tech Design URL:
CC:
Description:
Contains base layout and elements for New Tab Page Sections. Currently using mock data. Models and element actions will be added in later as part of New Tab Page sections project.
Steps to test this PR:
Definition of Done (Internal Only):
Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template