-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Tab Page layout and base elements #3008
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking nice. Some comments but feel free to merge when/if you address them.
The gap between the bottom and customise button seems quite big, but maybe that's deliberate?
Anyway, good job.
DuckDuckGo/FavoritesView.swift
Outdated
} | ||
|
||
private func emptyIcon() -> Image { | ||
Image(systemName: "square.grid.3x3.middle.filled") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This deliberate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is temporary - wanted to have anything other than blank view displayed. I'll remove that when integrating favorites.
Decided to remove it right now. Since there is a shadow and white background items are visible without an icon.
struct NewTabPageCustomizeButtonView: View { | ||
var body: some View { | ||
HStack { | ||
Image(.options16) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this autogenerated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. These are autogenerated asset symbols.
Yes, in fact it should be even bigger - there was a change on designs. I'll adjust that. |
Use proper empty state view for favorites
* main: Fire a pixel when removing the VPN configuration (#3014) Release 7.127.0-0 (#3020) point to BSK branch (#3016) [DuckPlayer] - 3. URL management & FE comms (#3007) Bump BSK version (#3011) New Tab Page layout and base elements (#3008) Remove Privacy Pro from device once expired account is deleted (#3009) Improvements to subscription settings (#2959) Toggle reports limiter (#3005) Duck Player info Modal (#3006) Silence tunnel startup noise with no access token available (#2993) In case Pending Deletion flag is nil, populate it with 'false' value (#2997) VPN uninstall not stopping agent in App Store build (#2999) Update VPN metadata to include entitlement (#3002)
* main: (24 commits) Add pixels to measure baseline for New Tab Page sections (#3024) backgrounding UI tests (#3021) improve bookmarks and favorites UI tests (#3019) [DuckPlayer] - 4. Remote Config (#3018) Updates BSK Fix issue when cancelling a download (#3030) Tentative fix for a crash and connectivity issues (#3027) autofill UI tests (#3012) scripts for running UI tests (#3000) Integrate RemoteMessaging with NewTabPage (#3017) Update to iOS 15 deployment target (#3001) Fire a pixel when removing the VPN configuration (#3014) Release 7.127.0-0 (#3020) point to BSK branch (#3016) [DuckPlayer] - 3. URL management & FE comms (#3007) Bump BSK version (#3011) New Tab Page layout and base elements (#3008) Remove Privacy Pro from device once expired account is deleted (#3009) Improvements to subscription settings (#2959) Toggle reports limiter (#3005) ...
Task/Issue URL: https://app.asana.com/0/1206226850447395/1207685167967158/f
Tech Design URL:
CC:
Description:
Contains base layout and elements for New Tab Page Sections. Currently using mock data. Models and element actions will be added in later as part of New Tab Page sections project.
Steps to test this PR:
Definition of Done (Internal Only):
Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template