-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to iOS 15 deployment target #3001
Conversation
-destination "platform=iOS Simulator,name=iPhone 14" \ | ||
-destination "platform=iOS Simulator,name=iPhone 15" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was getting workflow failures without this change.
@samsymons Changes looks ok, maybe we should try running some flows (e2e tests, ad hoc build) from this branch? |
* main: Fire a pixel when removing the VPN configuration (#3014) Release 7.127.0-0 (#3020) point to BSK branch (#3016) [DuckPlayer] - 3. URL management & FE comms (#3007) Bump BSK version (#3011) New Tab Page layout and base elements (#3008) Remove Privacy Pro from device once expired account is deleted (#3009) Improvements to subscription settings (#2959) Toggle reports limiter (#3005) Duck Player info Modal (#3006) Silence tunnel startup noise with no access token available (#2993) In case Pending Deletion flag is nil, populate it with 'false' value (#2997) VPN uninstall not stopping agent in App Store build (#2999) Update VPN metadata to include entitlement (#3002)
@bwaresiak I've updated the description to links of successful workflow runs. The remaining one I haven't tested is the Nightly Alpha workflow, but there's no good way to test it without publishing a real build to the alpha channel, and because the ad-hoc pipeline works (proving the ad-hoc target archives successfully) I feel it's acceptable. |
@samsymons yes that's great, thank you :) |
* main: (24 commits) Add pixels to measure baseline for New Tab Page sections (#3024) backgrounding UI tests (#3021) improve bookmarks and favorites UI tests (#3019) [DuckPlayer] - 4. Remote Config (#3018) Updates BSK Fix issue when cancelling a download (#3030) Tentative fix for a crash and connectivity issues (#3027) autofill UI tests (#3012) scripts for running UI tests (#3000) Integrate RemoteMessaging with NewTabPage (#3017) Update to iOS 15 deployment target (#3001) Fire a pixel when removing the VPN configuration (#3014) Release 7.127.0-0 (#3020) point to BSK branch (#3016) [DuckPlayer] - 3. URL management & FE comms (#3007) Bump BSK version (#3011) New Tab Page layout and base elements (#3008) Remove Privacy Pro from device once expired account is deleted (#3009) Improvements to subscription settings (#2959) Toggle reports limiter (#3005) ...
Task/Issue URL: https://app.asana.com/0/414235014887631/1207384568093628/f
Tech Design URL:
CC:
Description:
This PR updates the app to use an iOS 15 deployment target.
I've intentionally avoided cleaning up availability checks to keep this PR small and simple, in case it needs to be reverted last-minute. After the change has been released and looks good, I'll clean up the availability checks.
Each target in the app had overridden the deployment target, so I removed those overrides in favour of having each target inherit the deployment target from the parent project settings. Now we only have to change one value to set the deployment target across the board.
Workflow Runs:
Steps to test this PR:
Definition of Done (Internal Only):
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template