client: minor refactors for RoomSettingsForm #1762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 30, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1762 +/- ##
================================================
+ Coverage 62.7959% 62.8108% +0.0149%
================================================
Files 168 168
Lines 24879 24889 +10
Branches 1444 1444
================================================
+ Hits 15623 15633 +10
Misses 9203 9203
Partials 53 53 ☔ View full report in Codecov by Sentry. |
Passing run #1954 ↗︎
Details:
Review all test suite changes for PR #1762 ↗︎ |
|||||||||||||||
Base automatically changed from
04-30-client_make_restore_queue_setting_dropdown_same_size_as_others
to
master
April 30, 2024 13:49
dyc3
force-pushed
the
04-30-client_minor_refactors_for_roomsettingsform
branch
from
8da22ae
to
0a645a2
Compare
dyc3
changed the base branch from
master
to
04-30-server_send_details_of_zod_validation_errors
This was referenced Apr 30, 2024
dyc3
changed the base branch from
04-30-server_send_details_of_zod_validation_errors
to
04-30-client_upgrade_vuetify_to_3.5.17
dyc3
force-pushed
the
04-30-client_minor_refactors_for_roomsettingsform
branch
from
0a645a2
to
2b7d80f
Compare
dyc3
force-pushed
the
04-30-client_upgrade_vuetify_to_3.5.17
branch
from
e347440
to
3936cb7
Compare
Base automatically changed from
04-30-client_upgrade_vuetify_to_3.5.17
to
master
April 30, 2024 16:19
dyc3
force-pushed
the
04-30-client_minor_refactors_for_roomsettingsform
branch
from
2b7d80f
to
a82bc65
Compare
Bundle size diffdiff -u /tmp/bundle-size-base.txt/bundle-size.txt /tmp/bundle-size-head.txt/bundle-size.txt
--- /tmp/bundle-size-base.txt/bundle-size.txt 2024-04-30 20:48:39.418774522 +0000
+++ /tmp/bundle-size-head.txt/bundle-size.txt 2024-04-30 20:48:40.210769164 +0000
@@ -30,7 +30,7 @@
�[2mdist/�[22m�[2massets/�[22m�[36mAttribution-hash.js �[39m�[1m�[2m 0.34 kB�[22m�[1m�[22m�[2m │ gzip: 0.26 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mNotFound-hash.js �[39m�[1m�[2m 0.60 kB�[22m�[1m�[22m�[2m │ gzip: 0.32 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mplaceholder-hash.js �[39m�[1m�[2m 1.04 kB�[22m�[1m�[22m�[2m │ gzip: 0.48 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mPasswordReset-hash.js �[39m�[1m�[2m 2.00 kB�[22m�[1m�[22m�[2m │ gzip: 0.96 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mPasswordReset-hash.js �[39m�[1m�[2m 2.00 kB�[22m�[1m�[22m�[2m │ gzip: 0.95 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mRoomList-hash.js �[39m�[1m�[2m 2.31 kB�[22m�[1m�[22m�[2m │ gzip: 1.08 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mPrivacy-hash.js �[39m�[1m�[2m 2.64 kB�[22m�[1m�[22m�[2m │ gzip: 1.29 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mHome-hash.js �[39m�[1m�[2m 5.43 kB�[22m�[1m�[22m�[2m │ gzip: 1.34 kB�[22m
@@ -38,11 +38,11 @@
�[2mdist/�[22m�[2massets/�[22m�[36mde-hash.js �[39m�[1m�[2m 10.79 kB�[22m�[1m�[22m�[2m │ gzip: 4.49 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mfr-hash.js �[39m�[1m�[2m 11.59 kB�[22m�[1m�[22m�[2m │ gzip: 4.79 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mru-hash.js �[39m�[1m�[2m 12.40 kB�[22m�[1m�[22m�[2m │ gzip: 6.42 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mes-hash.js �[39m�[1m�[2m 14.05 kB�[22m�[1m�[22m�[2m │ gzip: 5.98 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mes-hash.js �[39m�[1m�[2m 14.05 kB�[22m�[1m�[22m�[2m │ gzip: 5.97 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mPeertubePlayer-hash.js �[39m�[1m�[2m 16.35 kB�[22m�[1m�[22m�[2m │ gzip: 5.54 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mVimeoPlayer-hash.js �[39m�[1m�[2m 39.99 kB�[22m�[1m�[22m�[2m │ gzip: 12.52 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mRoom-hash.js �[39m�[1m�[2m 161.82 kB�[22m�[1m�[22m�[2m │ gzip: 50.73 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mRoom-hash.js �[39m�[1m�[2m 161.86 kB�[22m�[1m�[22m�[2m │ gzip: 50.78 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mGoogleDrivePlayer-hash.js �[39m�[1m�[33m 604.87 kB�[39m�[22m�[2m │ gzip: 173.51 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mindex-hash.js �[39m�[1m�[33m 743.54 kB�[39m�[22m�[2m │ gzip: 248.18 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mPlyrPlayer-hash.js �[39m�[1m�[33m1,280.78 kB�[39m�[22m�[2m │ gzip: 379.37 kB�[22m
-�[32m✓ built in 25.92s�[39m
+�[32m✓ built in 25.98s�[39m |
dyc3
force-pushed
the
04-30-client_minor_refactors_for_roomsettingsform
branch
from
a82bc65
to
6300dbc
Compare
dyc3
force-pushed
the
04-30-client_minor_refactors_for_roomsettingsform
branch
2 times, most recently
from
cbc3563
to
5aecbcc
Compare
dyc3
force-pushed
the
04-30-client_minor_refactors_for_roomsettingsform
branch
from
5aecbcc
to
a4a6356
Compare
Passing run #1957 ↗︎
Details:
Review all test suite changes for PR #1762 ↗︎ |
|||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.