client: only submit changed settings to the server when changing settings #1765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 30, 2024
This was referenced Apr 30, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1765 +/- ##
================================================
+ Coverage 62.7944% 62.8243% +0.0298%
================================================
Files 168 168
Lines 24878 24898 +20
Branches 1444 1444
================================================
+ Hits 15622 15642 +20
Misses 9203 9203
Partials 53 53 ☔ View full report in Codecov by Sentry. |
Passing run #1966 ↗︎
Details:
Review all test suite changes for PR #1765 ↗︎ |
|||||||||||||||
dyc3
force-pushed
the
04-30-client_upgrade_vuetify_to_3.5.17
branch
from
8a122f3
to
e347440
Compare
dyc3
changed the base branch from
04-30-client_upgrade_vuetify_to_3.5.17
to
04-30-client_minor_refactors_for_roomsettingsform
dyc3
force-pushed
the
04-30-wip_use_reactive_
branch
from
dc7c858
to
9669da6
Compare
dyc3
force-pushed
the
04-30-client_minor_refactors_for_roomsettingsform
branch
from
2b7d80f
to
a82bc65
Compare
dyc3
force-pushed
the
04-30-wip_use_reactive_
branch
from
9669da6
to
af16137
Compare
Bundle size diffdiff -u /tmp/bundle-size-base.txt/bundle-size.txt /tmp/bundle-size-head.txt/bundle-size.txt
--- /tmp/bundle-size-base.txt/bundle-size.txt 2024-04-30 23:11:47.515397392 +0000
+++ /tmp/bundle-size-head.txt/bundle-size.txt 2024-04-30 23:11:47.751401114 +0000
@@ -3,7 +3,7 @@
�[32m✓�[39m 811 modules transformed.
rendering chunks...
computing gzip size...
-�[2mdist/�[22m�[32mindex.html �[39m�[1m�[2m 0.90 kB�[22m�[1m�[22m�[2m │ gzip: 0.52 kB�[22m
+�[2mdist/�[22m�[32mindex.html �[39m�[1m�[2m 0.90 kB�[22m�[1m�[22m�[2m │ gzip: 0.53 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[32mpop-hash.ogg �[39m�[1m�[2m 6.63 kB�[22m�[1m�[22m
�[2mdist/�[22m�[2massets/�[22m�[32mroboto-hash.woff2 �[39m�[1m�[2m 9.63 kB�[22m�[1m�[22m
�[2mdist/�[22m�[2massets/�[22m�[32mroboto-hash.woff2 �[39m�[1m�[2m 9.64 kB�[22m�[1m�[22m
@@ -30,19 +30,19 @@
�[2mdist/�[22m�[2massets/�[22m�[36mAttribution-hash.js �[39m�[1m�[2m 0.34 kB�[22m�[1m�[22m�[2m │ gzip: 0.26 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mNotFound-hash.js �[39m�[1m�[2m 0.60 kB�[22m�[1m�[22m�[2m │ gzip: 0.32 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mplaceholder-hash.js �[39m�[1m�[2m 1.04 kB�[22m�[1m�[22m�[2m │ gzip: 0.48 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mPasswordReset-hash.js �[39m�[1m�[2m 2.00 kB�[22m�[1m�[22m�[2m │ gzip: 0.95 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mPasswordReset-hash.js �[39m�[1m�[2m 2.00 kB�[22m�[1m�[22m�[2m │ gzip: 0.96 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mRoomList-hash.js �[39m�[1m�[2m 2.31 kB�[22m�[1m�[22m�[2m │ gzip: 1.08 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mPrivacy-hash.js �[39m�[1m�[2m 2.64 kB�[22m�[1m�[22m�[2m │ gzip: 1.29 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mHome-hash.js �[39m�[1m�[2m 5.43 kB�[22m�[1m�[22m�[2m │ gzip: 1.34 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mYoutubePlayer-hash.js �[39m�[1m�[2m 5.86 kB�[22m�[1m�[22m�[2m │ gzip: 2.22 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mde-hash.js �[39m�[1m�[2m 10.79 kB�[22m�[1m�[22m�[2m │ gzip: 4.49 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mfr-hash.js �[39m�[1m�[2m 11.59 kB�[22m�[1m�[22m�[2m │ gzip: 4.78 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mfr-hash.js �[39m�[1m�[2m 11.59 kB�[22m�[1m�[22m�[2m │ gzip: 4.79 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mru-hash.js �[39m�[1m�[2m 12.40 kB�[22m�[1m�[22m�[2m │ gzip: 6.42 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mes-hash.js �[39m�[1m�[2m 14.05 kB�[22m�[1m�[22m�[2m │ gzip: 5.97 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mes-hash.js �[39m�[1m�[2m 14.05 kB�[22m�[1m�[22m�[2m │ gzip: 5.98 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mPeertubePlayer-hash.js �[39m�[1m�[2m 16.35 kB�[22m�[1m�[22m�[2m │ gzip: 5.54 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mVimeoPlayer-hash.js �[39m�[1m�[2m 39.99 kB�[22m�[1m�[22m�[2m │ gzip: 12.52 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mRoom-hash.js �[39m�[1m�[2m 161.85 kB�[22m�[1m�[22m�[2m │ gzip: 50.78 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mVimeoPlayer-hash.js �[39m�[1m�[2m 39.99 kB�[22m�[1m�[22m�[2m │ gzip: 12.53 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mRoom-hash.js �[39m�[1m�[2m 162.12 kB�[22m�[1m�[22m�[2m │ gzip: 50.89 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mGoogleDrivePlayer-hash.js �[39m�[1m�[33m 604.87 kB�[39m�[22m�[2m │ gzip: 173.51 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mindex-hash.js �[39m�[1m�[33m 743.54 kB�[39m�[22m�[2m │ gzip: 248.18 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mPlyrPlayer-hash.js �[39m�[1m�[33m1,280.78 kB�[39m�[22m�[2m │ gzip: 379.36 kB�[22m
-�[32m✓ built in 25.24s�[39m
+�[2mdist/�[22m�[2massets/�[22m�[36mindex-hash.js �[39m�[1m�[33m 743.54 kB�[39m�[22m�[2m │ gzip: 248.17 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mPlyrPlayer-hash.js �[39m�[1m�[33m1,280.78 kB�[39m�[22m�[2m │ gzip: 379.37 kB�[22m
+�[32m✓ built in 25.92s�[39m |
dyc3
force-pushed
the
04-30-client_minor_refactors_for_roomsettingsform
branch
from
a82bc65
to
6300dbc
Compare
dyc3
force-pushed
the
04-30-client_minor_refactors_for_roomsettingsform
branch
from
6300dbc
to
cbc3563
Compare
dyc3
changed the base branch from
04-30-client_minor_refactors_for_roomsettingsform
to
04-30-server_remove_deprecated_permissions_field_from_get__api_room__room_endpoint
dyc3
force-pushed
the
04-30-wip_use_reactive_
branch
from
af16137
to
bcd588a
Compare
dyc3
force-pushed
the
04-30-server_remove_deprecated_permissions_field_from_get__api_room__room_endpoint
branch
from
9c2fd53
to
2e35ba8
Compare
dyc3
force-pushed
the
04-30-wip_use_reactive_
branch
from
bcd588a
to
8e74109
Compare
dyc3
force-pushed
the
04-30-server_remove_deprecated_permissions_field_from_get__api_room__room_endpoint
branch
from
2e35ba8
to
34642b3
Compare
dyc3
force-pushed
the
04-30-wip_use_reactive_
branch
from
8e74109
to
3b4904e
Compare
dyc3
force-pushed
the
04-30-server_remove_deprecated_permissions_field_from_get__api_room__room_endpoint
branch
from
34642b3
to
e89e488
Compare
dyc3
force-pushed
the
04-30-wip_use_reactive_
branch
2 times, most recently
from
9539176
to
520ae8d
Compare
Base automatically changed from
04-30-server_remove_deprecated_permissions_field_from_get__api_room__room_endpoint
to
master
April 30, 2024 23:09
dyc3
force-pushed
the
04-30-wip_use_reactive_
branch
from
520ae8d
to
3a61b6a
Compare
Passing run #1967 ↗︎
Details:
Review all test suite changes for PR #1765 ↗︎ |
|||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.