Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: remove deprecated permissions field from GET /api/room/:room endpoint #1768

Conversation

dyc3
Copy link
Owner

@dyc3 dyc3 commented Apr 30, 2024

No description provided.

Copy link

github-actions bot commented Apr 30, 2024

Bundle size diff

diff -u /tmp/bundle-size-base.txt/bundle-size.txt /tmp/bundle-size-head.txt/bundle-size.txt
--- /tmp/bundle-size-base.txt/bundle-size.txt	2024-04-30 22:27:20.182824350 +0000
+++ /tmp/bundle-size-head.txt/bundle-size.txt	2024-04-30 22:27:21.090820956 +0000
@@ -41,8 +41,8 @@
 �[2mdist/�[22m�[2massets/�[22m�[36mes-hash.js                                 �[39m�[1m�[2m   14.05 kB�[22m�[1m�[22m�[2m │ gzip:   5.97 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[36mPeertubePlayer-hash.js                     �[39m�[1m�[2m   16.35 kB�[22m�[1m�[22m�[2m │ gzip:   5.54 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[36mVimeoPlayer-hash.js                        �[39m�[1m�[2m   39.99 kB�[22m�[1m�[22m�[2m │ gzip:  12.52 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mRoom-hash.js                               �[39m�[1m�[2m  161.86 kB�[22m�[1m�[22m�[2m │ gzip:  50.78 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mGoogleDrivePlayer-hash.js                  �[39m�[1m�[33m  604.87 kB�[39m�[22m�[2m │ gzip: 173.50 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mRoom-hash.js                               �[39m�[1m�[2m  161.85 kB�[22m�[1m�[22m�[2m │ gzip:  50.78 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mGoogleDrivePlayer-hash.js                  �[39m�[1m�[33m  604.87 kB�[39m�[22m�[2m │ gzip: 173.51 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[36mindex-hash.js                              �[39m�[1m�[33m  743.54 kB�[39m�[22m�[2m │ gzip: 248.18 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[36mPlyrPlayer-hash.js                         �[39m�[1m�[33m1,280.78 kB�[39m�[22m�[2m │ gzip: 379.36 kB�[22m
-�[32m✓ built in 25.36s�[39m
+�[32m✓ built in 25.85s�[39m

@dyc3 dyc3 force-pushed the 04-30-client_minor_refactors_for_roomsettingsform branch from 6300dbc to cbc3563 Compare April 30, 2024 19:43
@dyc3 dyc3 force-pushed the 04-30-server_remove_deprecated_permissions_field_from_get__api_room__room_endpoint branch from 0d16c10 to 9c2fd53 Compare April 30, 2024 19:43
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.7944%. Comparing base (cf03f77) to head (e89e488).

Additional details and impacted files
@@               Coverage Diff                @@
##             master      #1768        +/-   ##
================================================
- Coverage   62.8108%   62.7944%   -0.0165%     
================================================
  Files           168        168                
  Lines         24889      24878        -11     
  Branches       1444       1444                
================================================
- Hits          15633      15622        -11     
  Misses         9203       9203                
  Partials         53         53                

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dyc3 dyc3 marked this pull request as ready for review April 30, 2024 19:46
Copy link

cypress bot commented Apr 30, 2024

Passing run #1958 ↗︎

0 84 1 0 Flakiness 0

Details:

Merge e89e488 into cf03f77...
Project: OpenTogetherTube Commit: fa7a3eb76e ℹ️
Status: Passed Duration: 04:55 💡
Started: Apr 30, 2024 10:26 PM Ended: Apr 30, 2024 10:31 PM

Review all test suite changes for PR #1768 ↗︎

@dyc3 dyc3 force-pushed the 04-30-client_minor_refactors_for_roomsettingsform branch from cbc3563 to 5aecbcc Compare April 30, 2024 19:57
@dyc3 dyc3 force-pushed the 04-30-server_remove_deprecated_permissions_field_from_get__api_room__room_endpoint branch from 9c2fd53 to 2e35ba8 Compare April 30, 2024 20:03
@dyc3 dyc3 force-pushed the 04-30-client_minor_refactors_for_roomsettingsform branch from 5aecbcc to a4a6356 Compare April 30, 2024 20:45
@dyc3 dyc3 force-pushed the 04-30-server_remove_deprecated_permissions_field_from_get__api_room__room_endpoint branch from 2e35ba8 to 34642b3 Compare April 30, 2024 20:45
Base automatically changed from 04-30-client_minor_refactors_for_roomsettingsform to master April 30, 2024 22:21
@dyc3 dyc3 force-pushed the 04-30-server_remove_deprecated_permissions_field_from_get__api_room__room_endpoint branch from 34642b3 to e89e488 Compare April 30, 2024 22:25
Copy link
Owner Author

dyc3 commented Apr 30, 2024

Merge activity

  • Apr 30, 7:06 PM EDT: @dyc3 started a stack merge that includes this pull request via Graphite.
  • Apr 30, 7:09 PM EDT: @dyc3 merged this pull request with Graphite.

@dyc3 dyc3 merged commit a63aa8c into master Apr 30, 2024
26 of 33 checks passed
@dyc3 dyc3 deleted the 04-30-server_remove_deprecated_permissions_field_from_get__api_room__room_endpoint branch April 30, 2024 23:09
Copy link

cypress bot commented Apr 30, 2024

Passing run #1965 ↗︎

0 84 1 0 Flakiness 0

Details:

server: remove deprecated `permissions` field from `GET /api/room/:room` endpoin...
Project: OpenTogetherTube Commit: a63aa8ce99
Status: Passed Duration: 04:49 💡
Started: Apr 30, 2024 11:10 PM Ended: Apr 30, 2024 11:15 PM

Review all test suite changes for PR #1768 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant