-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server: remove deprecated permissions
field from GET /api/room/:room
endpoint
#1768
Merged
dyc3
merged 1 commit into
master
from
04-30-server_remove_deprecated_permissions_field_from_get__api_room__room_endpoint
Apr 30, 2024
Merged
server: remove deprecated permissions
field from GET /api/room/:room
endpoint
#1768
dyc3
merged 1 commit into
master
from
04-30-server_remove_deprecated_permissions_field_from_get__api_room__room_endpoint
Apr 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 30, 2024
Bundle size diffdiff -u /tmp/bundle-size-base.txt/bundle-size.txt /tmp/bundle-size-head.txt/bundle-size.txt
--- /tmp/bundle-size-base.txt/bundle-size.txt 2024-04-30 22:27:20.182824350 +0000
+++ /tmp/bundle-size-head.txt/bundle-size.txt 2024-04-30 22:27:21.090820956 +0000
@@ -41,8 +41,8 @@
�[2mdist/�[22m�[2massets/�[22m�[36mes-hash.js �[39m�[1m�[2m 14.05 kB�[22m�[1m�[22m�[2m │ gzip: 5.97 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mPeertubePlayer-hash.js �[39m�[1m�[2m 16.35 kB�[22m�[1m�[22m�[2m │ gzip: 5.54 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mVimeoPlayer-hash.js �[39m�[1m�[2m 39.99 kB�[22m�[1m�[22m�[2m │ gzip: 12.52 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mRoom-hash.js �[39m�[1m�[2m 161.86 kB�[22m�[1m�[22m�[2m │ gzip: 50.78 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mGoogleDrivePlayer-hash.js �[39m�[1m�[33m 604.87 kB�[39m�[22m�[2m │ gzip: 173.50 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mRoom-hash.js �[39m�[1m�[2m 161.85 kB�[22m�[1m�[22m�[2m │ gzip: 50.78 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mGoogleDrivePlayer-hash.js �[39m�[1m�[33m 604.87 kB�[39m�[22m�[2m │ gzip: 173.51 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mindex-hash.js �[39m�[1m�[33m 743.54 kB�[39m�[22m�[2m │ gzip: 248.18 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mPlyrPlayer-hash.js �[39m�[1m�[33m1,280.78 kB�[39m�[22m�[2m │ gzip: 379.36 kB�[22m
-�[32m✓ built in 25.36s�[39m
+�[32m✓ built in 25.85s�[39m |
6300dbc
to
cbc3563
Compare
0d16c10
to
9c2fd53
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1768 +/- ##
================================================
- Coverage 62.8108% 62.7944% -0.0165%
================================================
Files 168 168
Lines 24889 24878 -11
Branches 1444 1444
================================================
- Hits 15633 15622 -11
Misses 9203 9203
Partials 53 53 ☔ View full report in Codecov by Sentry. |
Passing run #1958 ↗︎Details:
Review all test suite changes for PR #1768 ↗︎ |
cbc3563
to
5aecbcc
Compare
9c2fd53
to
2e35ba8
Compare
5aecbcc
to
a4a6356
Compare
2e35ba8
to
34642b3
Compare
Base automatically changed from
04-30-client_minor_refactors_for_roomsettingsform
to
master
April 30, 2024 22:21
34642b3
to
e89e488
Compare
Passing run #1965 ↗︎Details:
Review all test suite changes for PR #1768 ↗︎ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.