client: auto submit room settings on change #1766

dyc3 · 2024-04-30T14:49:58Z

closes #1593

dyc3 · 2024-04-30T14:50:15Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dyc3 and the rest of your teammates on Graphite

codecov · 2024-04-30T14:53:24Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.8452%. Comparing base (c2f3921) to head (2c3bb53).

Additional details and impacted files

@@               Coverage Diff                @@
##             master      #1766        +/-   ##
================================================
+ Coverage   62.8243%   62.8452%   +0.0208%     
================================================
  Files           168        168                
  Lines         24898      24912        +14     
  Branches       1444       1444                
================================================
+ Hits          15642      15656        +14     
  Misses         9203       9203                
  Partials         53         53

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cypress · 2024-04-30T14:57:58Z

Passing run #1968 ↗︎

0	84	1	0	0

Details:

Merge `2c3bb53` into `c2f3921`...
Project: OpenTogetherTube	Commit: `3e633d7cbf ℹ️`
Status: Passed	Duration: 05:08 💡
Started: Apr 30, 2024 11:16 PM	Ended: Apr 30, 2024 11:21 PM

Review all test suite changes for PR #1766 ↗︎

github-actions · 2024-04-30T18:48:22Z

Bundle size diff

diff -u /tmp/bundle-size-base.txt/bundle-size.txt /tmp/bundle-size-head.txt/bundle-size.txt
--- /tmp/bundle-size-base.txt/bundle-size.txt	2024-04-30 23:17:00.032215657 +0000
+++ /tmp/bundle-size-head.txt/bundle-size.txt	2024-04-30 23:17:00.816220662 +0000
@@ -30,7 +30,7 @@
 �[2mdist/�[22m�[2massets/�[22m�[36mAttribution-hash.js                        �[39m�[1m�[2m    0.34 kB�[22m�[1m�[22m�[2m │ gzip:   0.26 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[36mNotFound-hash.js                           �[39m�[1m�[2m    0.60 kB�[22m�[1m�[22m�[2m │ gzip:   0.32 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[36mplaceholder-hash.js                        �[39m�[1m�[2m    1.04 kB�[22m�[1m�[22m�[2m │ gzip:   0.48 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mPasswordReset-hash.js                      �[39m�[1m�[2m    2.00 kB�[22m�[1m�[22m�[2m │ gzip:   0.96 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mPasswordReset-hash.js                      �[39m�[1m�[2m    2.00 kB�[22m�[1m�[22m�[2m │ gzip:   0.95 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[36mRoomList-hash.js                           �[39m�[1m�[2m    2.31 kB�[22m�[1m�[22m�[2m │ gzip:   1.08 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[36mPrivacy-hash.js                            �[39m�[1m�[2m    2.64 kB�[22m�[1m�[22m�[2m │ gzip:   1.29 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[36mHome-hash.js                               �[39m�[1m�[2m    5.43 kB�[22m�[1m�[22m�[2m │ gzip:   1.34 kB�[22m
@@ -40,9 +40,9 @@
 �[2mdist/�[22m�[2massets/�[22m�[36mru-hash.js                                 �[39m�[1m�[2m   12.40 kB�[22m�[1m�[22m�[2m │ gzip:   6.42 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[36mes-hash.js                                 �[39m�[1m�[2m   14.05 kB�[22m�[1m�[22m�[2m │ gzip:   5.97 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[36mPeertubePlayer-hash.js                     �[39m�[1m�[2m   16.35 kB�[22m�[1m�[22m�[2m │ gzip:   5.54 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mVimeoPlayer-hash.js                        �[39m�[1m�[2m   39.99 kB�[22m�[1m�[22m�[2m │ gzip:  12.53 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mRoom-hash.js                               �[39m�[1m�[2m  162.12 kB�[22m�[1m�[22m�[2m │ gzip:  50.89 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mVimeoPlayer-hash.js                        �[39m�[1m�[2m   39.99 kB�[22m�[1m�[22m�[2m │ gzip:  12.52 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mRoom-hash.js                               �[39m�[1m�[2m  164.05 kB�[22m�[1m�[22m�[2m │ gzip:  51.41 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[36mGoogleDrivePlayer-hash.js                  �[39m�[1m�[33m  604.87 kB�[39m�[22m�[2m │ gzip: 173.51 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[36mindex-hash.js                              �[39m�[1m�[33m  743.54 kB�[39m�[22m�[2m │ gzip: 248.18 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[36mPlyrPlayer-hash.js                         �[39m�[1m�[33m1,280.78 kB�[39m�[22m�[2m │ gzip: 379.37 kB�[22m
-�[32m✓ built in 24.88s�[39m
+�[32m✓ built in 25.46s�[39m

dyc3 · 2024-04-30T23:06:48Z

Merge activity

Apr 30, 7:06 PM EDT: @dyc3 started a stack merge that includes this pull request via Graphite.
Apr 30, 7:15 PM EDT: Graphite rebased this pull request as part of a merge.
Apr 30, 7:19 PM EDT: @dyc3 merged this pull request with Graphite.

cypress · 2024-04-30T23:26:06Z

Passing run #1969 ↗︎

0	84	1	0	0

Details:

client: auto submit room settings on change (#1766)
Project: OpenTogetherTube	Commit: `df311e305a`
Status: Passed	Duration: 05:34 💡
Started: Apr 30, 2024 11:20 PM	Ended: Apr 30, 2024 11:26 PM

Review all test suite changes for PR #1766 ↗︎

This was referenced Apr 30, 2024

client: upgrade vuetify to 3.5.17 #1764

Merged

client: minor refactors for RoomSettingsForm #1762

Merged

server: send details of zod validation errors #1763

Merged

dyc3 mentioned this pull request Apr 30, 2024

client: only submit changed settings to the server when changing settings #1765

Merged

dyc3 force-pushed the 04-30-wip_use_reactive_ branch from dc7c858 to 9669da6 Compare April 30, 2024 15:12

dyc3 force-pushed the 04-30-wip_also_auto_submits_settings_but_still_janky branch from 43a211b to 5bd10d5 Compare April 30, 2024 15:12

dyc3 force-pushed the 04-30-wip_use_reactive_ branch from 9669da6 to af16137 Compare April 30, 2024 18:46

dyc3 force-pushed the 04-30-wip_also_auto_submits_settings_but_still_janky branch from 5bd10d5 to 48dacb1 Compare April 30, 2024 18:46

dyc3 force-pushed the 04-30-wip_use_reactive_ branch from af16137 to bcd588a Compare April 30, 2024 19:43

dyc3 force-pushed the 04-30-wip_also_auto_submits_settings_but_still_janky branch from 48dacb1 to 3aa9296 Compare April 30, 2024 19:43

dyc3 mentioned this pull request Apr 30, 2024

server: remove deprecated permissions field from GET /api/room/:room endpoint #1768

Merged

dyc3 force-pushed the 04-30-wip_use_reactive_ branch from bcd588a to 8e74109 Compare April 30, 2024 20:03

dyc3 force-pushed the 04-30-wip_also_auto_submits_settings_but_still_janky branch from 3aa9296 to aa23064 Compare April 30, 2024 20:03

dyc3 force-pushed the 04-30-wip_use_reactive_ branch from 8e74109 to 3b4904e Compare April 30, 2024 22:11

dyc3 force-pushed the 04-30-wip_also_auto_submits_settings_but_still_janky branch from aa23064 to 5e6550f Compare April 30, 2024 22:11

dyc3 force-pushed the 04-30-wip_use_reactive_ branch from 3b4904e to 9539176 Compare April 30, 2024 22:25

dyc3 force-pushed the 04-30-wip_also_auto_submits_settings_but_still_janky branch from 5e6550f to 26ff667 Compare April 30, 2024 22:25

dyc3 force-pushed the 04-30-wip_use_reactive_ branch from 9539176 to 520ae8d Compare April 30, 2024 22:57

dyc3 force-pushed the 04-30-wip_also_auto_submits_settings_but_still_janky branch from 26ff667 to fc633a2 Compare April 30, 2024 22:57

dyc3 marked this pull request as ready for review April 30, 2024 23:03

dyc3 force-pushed the 04-30-wip_use_reactive_ branch from 520ae8d to 3a61b6a Compare April 30, 2024 23:09

Base automatically changed from 04-30-wip_use_reactive_ to master April 30, 2024 23:14

client: auto submit room settings on change

2c3bb53

dyc3 force-pushed the 04-30-wip_also_auto_submits_settings_but_still_janky branch from fc633a2 to 2c3bb53 Compare April 30, 2024 23:14

dyc3 merged commit df311e3 into master Apr 30, 2024
26 checks passed

dyc3 deleted the 04-30-wip_also_auto_submits_settings_but_still_janky branch April 30, 2024 23:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

client: auto submit room settings on change #1766

client: auto submit room settings on change #1766

dyc3 commented Apr 30, 2024 •

edited

Loading

dyc3 commented Apr 30, 2024 •

edited

Loading

codecov bot commented Apr 30, 2024 •

edited

Loading

cypress bot commented Apr 30, 2024 •

edited

Loading

github-actions bot commented Apr 30, 2024 •

edited

Loading

dyc3 commented Apr 30, 2024 •

edited

Loading

cypress bot commented Apr 30, 2024

client: auto submit room settings on change #1766

client: auto submit room settings on change #1766

Conversation

dyc3 commented Apr 30, 2024 • edited Loading

dyc3 commented Apr 30, 2024 • edited Loading

codecov bot commented Apr 30, 2024 • edited Loading

Codecov Report

cypress bot commented Apr 30, 2024 • edited Loading

Passing run #1968 ↗︎

Review all test suite changes for PR #1766 ↗︎

github-actions bot commented Apr 30, 2024 • edited Loading

Bundle size diff

dyc3 commented Apr 30, 2024 • edited Loading

Merge activity

cypress bot commented Apr 30, 2024

Passing run #1969 ↗︎

Review all test suite changes for PR #1766 ↗︎

dyc3 commented Apr 30, 2024 •

edited

Loading

dyc3 commented Apr 30, 2024 •

edited

Loading

codecov bot commented Apr 30, 2024 •

edited

Loading

cypress bot commented Apr 30, 2024 •

edited

Loading

github-actions bot commented Apr 30, 2024 •

edited

Loading

dyc3 commented Apr 30, 2024 •

edited

Loading