-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safari Button #5
Comments
I like that, it seems too insignificant to have in the app, especially displayed so prominently. I'll delete it, if we ever need it in the future we can put it in the sharesheet. |
This is now done. |
federicocappelli
added a commit
that referenced
this issue
Jul 5, 2024
Task/Issue URL: https://app.asana.com/0/1205842942115003/1206805455884775/f Tech Design URL: https://app.asana.com/0/1205842942115003/1207147511614062/f This PR updates BSK from duckduckgo/BrowserServicesKit#874 and contains all the needed refactoring for the Subscription classes inits. It also contains a new unit test class: - SubscriptionPagesUseSubscriptionFeatureTests Complete tests will be implemented in follow-up tasks
samsymons
added a commit
that referenced
this issue
Jul 7, 2024
# By Christopher Brind (3) and others # Via Anh Do (1) and GitHub (1) * main: Add connection tester failure pixels (#3049) Release 7.127.0-1 (#3051) fix bug not clearing ui properly on autoclear (#3050) widget UI tests (#3042) fix autofill widget failure (#3040) macOS BSK change: De-duplicate passwords on import (#3048) Privacy Dashboard refactor (#3038) Make Maestro tests fail on flow cancellation (#3036) Improve VPN logging logic (#3032) Subscription refactoring #5 (#3023) Update Sync error pixels (#3046) Fixes App Data Clearing State Status In Settings (#3041) update sync error copy (#2870) Fixes for Xcode 16 (BSK -> 164.3.0) (#3035) Update the Privacy Pro status attribute matcher (#3033) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think we can remove the safari button. Presumably they are here for a different reason, not to open in Safari.
The text was updated successfully, but these errors were encountered: