Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

widget UI tests #3042

Merged
merged 15 commits into from
Jul 5, 2024
Merged

widget UI tests #3042

merged 15 commits into from
Jul 5, 2024

Conversation

brindy
Copy link
Contributor

@brindy brindy commented Jul 4, 2024

Task/Issue URL: https://app.asana.com/0/392891325557410/1207589761442410/f
Tech Design URL:
CC:

Description:
Adds preliminarily widget tests.

The contents of the widget are not testable so am only checking the first widget launches the app and that they appear in the expected order in the widget picker.

Steps to test this PR:

  1. Run the flow release/widgets.yaml

@brindy brindy requested a review from loremattei July 4, 2024 18:00
@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Jul 4, 2024
Copy link
Contributor

@loremattei loremattei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub diffs logic gets confused by squash and merge :-)
backgrounding.yaml is already merged in main from a different branch.

The code that actually changed in this PR looks good to me :-)

:shipit:

@brindy brindy removed the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Jul 5, 2024
@brindy brindy merged commit 3c07306 into main Jul 5, 2024
22 of 24 checks passed
@brindy brindy deleted the brindy/widget-ui-tests branch July 5, 2024 16:41
samsymons added a commit that referenced this pull request Jul 7, 2024
# By Christopher Brind (3) and others
# Via Anh Do (1) and GitHub (1)
* main:
  Add connection tester failure pixels (#3049)
  Release 7.127.0-1 (#3051)
  fix bug not clearing ui properly on autoclear (#3050)
  widget UI tests (#3042)
  fix autofill widget failure (#3040)
  macOS BSK change: De-duplicate passwords on import (#3048)
  Privacy Dashboard refactor (#3038)
  Make Maestro tests fail on flow cancellation (#3036)
  Improve VPN logging logic (#3032)
  Subscription refactoring #5 (#3023)
  Update Sync error pixels (#3046)
  Fixes App Data Clearing State Status In Settings (#3041)
  update sync error copy (#2870)
  Fixes for Xcode 16 (BSK -> 164.3.0) (#3035)
  Update the Privacy Pro status attribute matcher (#3033)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants