Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add connection tester failure pixels #3049

Merged
merged 5 commits into from
Jul 6, 2024
Merged

Add connection tester failure pixels #3049

merged 5 commits into from
Jul 6, 2024

Conversation

diegoreymendez
Copy link
Contributor

@diegoreymendez diegoreymendez commented Jul 5, 2024 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/1206580121312550/1207743877093953/f

macOS PR: duckduckgo/macos-browser#2948
BSK PR: duckduckgo/BrowserServicesKit#881

Description

Adds pixels to track connection tester failures and recovery. These should give us a better idea about how users are faring.

Testing

  1. Open Console.app, filter by "Pixel fired" and start streaming from your iPhone.
  2. Download the ruleset.txt file to your desktop
  3. Start the VPN.
  4. Check that it works.
  5. Run the command: sudo pfctl -ef ~/Desktop/ruleset.txt
  6. It can take up to 15 seconds for the first pixels to show:
Pixel fired m_netp_connection_tester_failure_d [:]
Pixel fired m_netp_connection_tester_failure_c [:]
Pixel fired m_netp_connection_tester_failure_recovered_d ["count": "1"]
Pixel fired m_netp_connection_tester_failure_recovered_c ["count": "1"]
  1. The extended failures are hard to test because we don't have support for simulating extended failures in the connection tester, but I think we can expect that this will work fine if it did in the macOS PR.

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie ’ rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme
Internal references:

Software Engineering Expectations
Technical Design Template

@diegoreymendez diegoreymendez self-assigned this Jul 5, 2024
This was referenced Jul 5, 2024
Merged
Merged
@diegoreymendez diegoreymendez marked this pull request as ready for review July 5, 2024 14:54
@diegoreymendez diegoreymendez marked this pull request as draft July 5, 2024 14:54
@diegoreymendez diegoreymendez marked this pull request as ready for review July 5, 2024 15:07
diegoreymendez
diegoreymendez commented Jul 5, 2024
View reviewed changes
PacketTunnelProvider/NetworkProtection/NetworkProtectionPacketTunnelProvider.swift Outdated
@@ -48,6 +48,36 @@ final class NetworkProtectionPacketTunnelProvider: PacketTunnelProvider {
DailyPixel.fire(pixel: .networkProtectionActiveUser,
withAdditionalParameters: [PixelParameters.vpnCohort: UniquePixel.cohort(from: defaults.vpnFirstEnabled)],
includedParameters: [.appVersion, .atb])
case .connectionTesterStatusChange(let status):
vpnLogger.log(status)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also log these to console.

diegoreymendez added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Jul 6, 2024
@diegoreymendez
Add connection tester failure pixels (#881)
0746af0 
Task/Issue URL: https://app.asana.com/0/1206580121312550/1207743877093953/f

iOS PR: duckduckgo/iOS#3049
macOS PR: duckduckgo/macos-browser#2948

What kind of version bump will this require?: Patch

## Description

Adds pixels to track connection tester failures and recovery.  These should give us a better idea about how users are faring.
@diegoreymendez diegoreymendez merged commit 094fdf3 into main Jul 6, 2024
14 checks passed
@diegoreymendez diegoreymendez deleted the diego/pixel-tunnel-down branch July 6, 2024 12:32
diegoreymendez added a commit to duckduckgo/macos-browser that referenced this pull request Jul 6, 2024
@diegoreymendez
Add connection tester failure pixels (#2948)
5915175 
Task/Issue URL:
https://app.asana.com/0/1206580121312550/1207743877093953/f

iOS PR: duckduckgo/iOS#3049
BSK PR: duckduckgo/BrowserServicesKit#881

## Description

Adds pixels to track connection tester failures and recovery. These
should give us a better idea about how users are faring.
samsymons added a commit that referenced this pull request Jul 7, 2024
@samsymons
Merge branch 'main' into sam/vpn-snooze-initial-support
4167d6f 
# By Christopher Brind (3) and others
# Via Anh Do (1) and GitHub (1)
* main:
  Add connection tester failure pixels (#3049)
  Release 7.127.0-1 (#3051)
  fix bug not clearing ui properly on autoclear (#3050)
  widget UI tests (#3042)
  fix autofill widget failure (#3040)
  macOS BSK change: De-duplicate passwords on import (#3048)
  Privacy Dashboard refactor (#3038)
  Make Maestro tests fail on flow cancellation (#3036)
  Improve VPN logging logic (#3032)
  Subscription refactoring #5 (#3023)
  Update Sync error pixels (#3046)
  Fixes App Data Clearing State Status In Settings (#3041)
  update sync error copy (#2870)
  Fixes for Xcode 16 (BSK -> 164.3.0) (#3035)
  Update the Privacy Pro status attribute matcher (#3033)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
mgurgel pushed a commit to duckduckgo/BrowserServicesKit that referenced this pull request Jul 8, 2024
@diegoreymendez @mgurgel
Add connection tester failure pixels (#881)
1c81413 
Task/Issue URL: https://app.asana.com/0/1206580121312550/1207743877093953/f

iOS PR: duckduckgo/iOS#3049
macOS PR: duckduckgo/macos-browser#2948

What kind of version bump will this require?: Patch

## Description

Adds pixels to track connection tester failures and recovery.  These should give us a better idea about how users are faring.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quanganhdo quanganhdo quanganhdo approved these changes

@samsymons samsymons Awaiting requested review from samsymons

Assignees

@diegoreymendez diegoreymendez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diegoreymendez @quanganhdo