Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privacy Dashboard refactor #3038

Merged
merged 11 commits into from
Jul 5, 2024
Merged

Privacy Dashboard refactor #3038

merged 11 commits into from
Jul 5, 2024

Conversation

jaceklyp
Copy link
Contributor

@jaceklyp jaceklyp commented Jul 4, 2024

Task/Issue URL: https://app.asana.com/0/1201392122292466/1207677104594315/f

Description: See BSK PR description
Steps to test this PR: See BSK PR description

Definition of Done (Internal Only):

@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Jul 4, 2024
Copy link

github-actions bot commented Jul 4, 2024

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS against be06cd4

@jaceklyp jaceklyp removed the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Jul 4, 2024
@jaceklyp jaceklyp requested a review from ayoy July 4, 2024 17:32
Copy link
Contributor

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪

jaceklyp added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Jul 5, 2024
Required:

Task/Issue URL: https://app.asana.com/0/1201392122292466/1207677104594315/f
iOS PR: duckduckgo/iOS#3038
macOS PR: duckduckgo/macos-browser#2943
What kind of version bump will this require?: Major

Description:

- remove old pixels,
- remove user behavior toast experiment,
- refactor Privacy Dashboard,
- add documentation,
- test Privacy Dashboard
@jaceklyp jaceklyp merged commit effc931 into main Jul 5, 2024
14 checks passed
@jaceklyp jaceklyp deleted the jacek/privacy-dashboard-refactor branch July 5, 2024 15:53
samsymons added a commit that referenced this pull request Jul 7, 2024
# By Christopher Brind (3) and others
# Via Anh Do (1) and GitHub (1)
* main:
  Add connection tester failure pixels (#3049)
  Release 7.127.0-1 (#3051)
  fix bug not clearing ui properly on autoclear (#3050)
  widget UI tests (#3042)
  fix autofill widget failure (#3040)
  macOS BSK change: De-duplicate passwords on import (#3048)
  Privacy Dashboard refactor (#3038)
  Make Maestro tests fail on flow cancellation (#3036)
  Improve VPN logging logic (#3032)
  Subscription refactoring #5 (#3023)
  Update Sync error pixels (#3046)
  Fixes App Data Clearing State Status In Settings (#3041)
  update sync error copy (#2870)
  Fixes for Xcode 16 (BSK -> 164.3.0) (#3035)
  Update the Privacy Pro status attribute matcher (#3033)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
@SlayterDev SlayterDev restored the jacek/privacy-dashboard-refactor branch August 15, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants