Update the Privacy Pro status attribute matcher #3033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsymons
commented
Jul 3, 2024
| privacyProIsActive = true | ||
| privacyProIsExpiring = true |
There was a problem hiding this comment.
We no longer match multiple statuses for expiring users, as we can now match multiple statuses at once using an array in the RMF manifest.
6 tasks
samsymons
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Jul 4, 2024
Required: Task/Issue URL: https://app.asana.com/0/1199333091098016/1207731341550989/f iOS PR: duckduckgo/iOS#3033 macOS PR: duckduckgo/macos-browser#2940 What kind of version bump will this require?: Patch (technically the public API has not changed) Description: This PR updates the Privacy Pro status attribute to match an array instead of a string.
samsymons
added a commit
that referenced
this pull request
Jul 7, 2024
# By Christopher Brind (3) and others # Via Anh Do (1) and GitHub (1) * main: Add connection tester failure pixels (#3049) Release 7.127.0-1 (#3051) fix bug not clearing ui properly on autoclear (#3050) widget UI tests (#3042) fix autofill widget failure (#3040) macOS BSK change: De-duplicate passwords on import (#3048) Privacy Dashboard refactor (#3038) Make Maestro tests fail on flow cancellation (#3036) Improve VPN logging logic (#3032) Subscription refactoring #5 (#3023) Update Sync error pixels (#3046) Fixes App Data Clearing State Status In Settings (#3041) update sync error copy (#2870) Fixes for Xcode 16 (BSK -> 164.3.0) (#3035) Update the Privacy Pro status attribute matcher (#3033) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1199333091098016/1207731341550989/f
Tech Design URL:
CC:
Description:
This PR updates the Privacy Pro status attribute matcher to accept an array.
On the client side, it also makes it so that the
activecase no longer also targets expiring users. If we want to target both active and expiring users, we can do so by specifying multiple cases in the array.Steps to test this PR:
Definition of Done (Internal Only):
Copy Testing:
’rather than'Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template