-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for the degree function #3298
Conversation
…hs/Oscar.jl into fix_sub_and_quo_for_modules
What is the plan for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just adding this here, so that we don't accidentally merge this without resolving the :task
question.
Edit: This seems to be about the flattenings of modules over rather exotic rings. These can not be expected
If one proceeds by
The only thing I found so far is that the |
The idea is to do that issue in a separate PR. This one should limit to the degree check question. |
Reduction is part of the layer. |
@jankoboehm : This is not a citation, but what you said, correct? In any case, I have a fix now and I understand why it worked on master but not here. This can be pushed to #3348 . But it will be several hundred lines of code unrelated with this PR's original intention. So I think, it should also go separately. |
I had no choice but to also include the changes of the flattenings of modules. Otherwise the tests wouldn't run again. Also, they were running for the wrong reasons before, so I think, it's better this way. |
Good to be merged. Only non-required tests have not run yet and I don't see how to trigger them. |
This comment was marked as outdated.
This comment was marked as outdated.
@benlorenz @aaruni96 some heads-up for the backport: This PR introduced some code that is not compatible with AbstractAlgebra v0.40.0. For the master branch, this was replaced by the new interface in #3374. For the backporting of these two commits, you probably either need to keep the order as on the master branch (first cherry-pick this and #3374 afterwards), or apply |
Thanks for the info, I did backport #3374 earlier today with some small conflicts that I needed to resolve. (due to not having this PR yet) |
* Remove :task from sub methods for modules. * Introduce new function submodule. * Remove all deprecated uses of sub. * Export submodule. * Fix tests. * Fix tests again. * Register morphisms in general. * Rebase network of natural maps on WeakKeyIdDicts. * Clean up the morphisms network and dont store the actual morphisms. * Some small fix for Wolfram. * Some fixes and marking the test as broken again. * Fix documentation. * Another small fix for Wolfram. * Fix the fix. * Fix method selection. * Introduce kw argument for caching morphisms. * Redirect previous usages. * Adjust tests. * submodule -> sub_object. * Fix docstrings and signatures for quo. * Fix methods for quo. * Adjust documentation. * Fix up usages of quo. * Export new functions. * Some fixes. * Fix tests. * Fix tests. * Fix tests. * Fix tests. * Fix tests. * Fix tests. * Squashed changes. * Fix tests. * Fix up the truncation. * New rebase. * Fix tests. * WIP with debug messages. * Progress in debugging. * WIP on debugging. * Write truely generic presentation and kernel methods [no ci]. * Repair graded_map to accept zero entries. * Add tensor decomposition function to return value. * Add some assertions. * Repair kernel routine. * Rewrite hom methods for modules. * Add generic method for simplification of SubquoModuleElems. * Add missing check argument. * Fix or disable brittle tests. * Fix faulty merge. * Go back to old hom. * Switch tests to old hom. * Clean up some deprecated assertions. * Repair truncate. * Disable internal checks. * Update docs/src/CommutativeAlgebra/ModulesOverMultivariateRings/free_modules.md * Revert "Go back to old hom." This reverts commit a6b7c15. * Revert "Switch tests to old hom." This reverts commit 178eaf3. * Disable duplicate method. * Adjust printing. * Fix tests. * Fix keyword argument for duals. * Fix doctests. * Fix tests. * Fix doctests. * Delete some falsely added files. * Remove deprecated code. * Another round of disabling internal checks. * Disable various internal checks. * Disable further internal checks. * Set random seeds in tests. * Adjust use of keyword argument. * Fix more random seeds. * Fix the generic simplify method for SubquoModuleElems. * Revert "Remove deprecated code." This reverts commit 190256b. * Repair revert to old hom. * Repair preimage function. * Repair degree function. * Adjust tests to use of repaired old hom. * Add dummy simplify function for FreeModuleElems. * Fix doctests. * Repair simplify. * Fix documentation. * Fix doctests. * Some tuning. * Fix tests. * Bugfix from running book code run. * Remove some debugging artifacts. * Fix faulty merge. * Restrict signature. * Update flattenings of modules over towers of polynomial rings to make the tests run again. * Small fix. * Disable the superfluous kernel routine. * Restrict some further signatures to cases Singular can handle. * Add tests for flattenings of modules. * Readd methods which are not superfluous, yet. --------- Co-authored-by: Lars Göttgens <[email protected]> Co-authored-by: Lars Göttgens <[email protected]> (cherry picked from commit cfb3413)
### Backported PRs - [x] #3367 - [x] #3379 - [x] #3369 - [x] #3291 - [x] #3325 - [x] #3350 - [x] #3351 - [x] #3365 - [x] #3366 - [x] #3382 - [x] #3373 - [x] #3341 - [x] #3346 - [x] #3381 - [x] #3385 - [x] #3387 - [x] #3398 - [x] #3399 - [x] #3374 - [x] #3406 - [x] #2823 - [x] #3298 - [x] #3386 - [x] #3412 - [x] #3392 - [x] #3415 - [x] #3394 - [x] #3391
This addresses #2999 .
The PR contains the improved changes from #3238, rebased on #3237.
It can be rebased again, once #3237 is merged.
For the last testset in
test/Modules/ModulesGraded.jl
I now get the following timings:so the gradings still seem to make things slower. But computations now at least finish in comparable time.