Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Grassmann Pluecker #3382

Merged
merged 5 commits into from
Feb 19, 2024
Merged

Fix Grassmann Pluecker #3382

merged 5 commits into from
Feb 19, 2024

Conversation

antonydellavecchia
Copy link
Collaborator

@antonydellavecchia antonydellavecchia commented Feb 16, 2024

grassmann_pluecker_ideal returns ideal with knowledge of the the computed groebner basis

related to #3374

@antonydellavecchia antonydellavecchia added the backport 1.0.x Should be backported to the release 1.0 branch label Feb 16, 2024
Copy link

codecov bot commented Feb 17, 2024

Codecov Report

Merging #3382 (5d6a6ac) into master (82f6440) will decrease coverage by 0.03%.
Report is 11 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3382      +/-   ##
==========================================
- Coverage   82.08%   82.06%   -0.03%     
==========================================
  Files         556      557       +1     
  Lines       74072    73973      -99     
==========================================
- Hits        60805    60704     -101     
- Misses      13267    13269       +2     
Files Coverage Δ
src/Rings/mpoly-ideals.jl 94.08% <100.00%> (-0.03%) ⬇️

... and 32 files with indirect coverage changes

@thofma
Copy link
Collaborator

thofma commented Feb 17, 2024

I think it would be unfortunate to call the function blabla_ideal and not return an ideal. What about returning an ideal, which knows this Gröbner basis computed by polymake? If you agree, I can give it a try.

@antonydellavecchia
Copy link
Collaborator Author

antonydellavecchia commented Feb 17, 2024

I think it would be unfortunate to call the function blabla_ideal and not return an ideal. What about returning an ideal, which knows this Gröbner basis computed by polymake? If you agree, I can give it a try.

Ya that would be ideal.

@thofma
Copy link
Collaborator

thofma commented Feb 17, 2024

OK, this was easier than expected. I also took the liberty to clean up one of the conversions.

src/Rings/mpoly-ideals.jl Outdated Show resolved Hide resolved
src/Rings/mpoly-ideals.jl Outdated Show resolved Hide resolved
@benlorenz benlorenz mentioned this pull request Feb 17, 2024
33 tasks
@antonydellavecchia antonydellavecchia merged commit 7433548 into master Feb 19, 2024
24 checks passed
@antonydellavecchia antonydellavecchia deleted the adv/fix-grasmann-pluecker branch February 19, 2024 09:12
benlorenz pushed a commit that referenced this pull request Feb 19, 2024
* fixed

* fix for symmetric intersections test

* back to the roots

* revert

* Apply suggestions from code review

Co-authored-by: Benjamin Lorenz <[email protected]>

---------

Co-authored-by: Tommy Hofmann <[email protected]>
Co-authored-by: Benjamin Lorenz <[email protected]>
(cherry picked from commit 7433548)
@benlorenz benlorenz removed the backport 1.0.x Should be backported to the release 1.0 branch label Feb 19, 2024
benlorenz added a commit that referenced this pull request Feb 23, 2024
### Backported PRs

- [x] #3367
- [x] #3379 
- [x] #3369
- [x] #3291
- [x] #3325
- [x] #3350 
- [x] #3351
- [x] #3365 
- [x] #3366
- [x] #3382
- [x] #3373
- [x] #3341
- [x] #3346
- [x] #3381
- [x] #3385
- [x] #3387 
- [x] #3398 
- [x] #3399 
- [x] #3374 
- [x] #3406 
- [x] #2823
- [x] #3298
- [x] #3386 
- [x] #3412 
- [x] #3392 
- [x] #3415 
- [x] #3394
- [x] #3391
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants