Tweak exterior_algebra tests
#3415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not just verify that certain `exterior_algebra` invocations don't error out; also check that the returned values satisfy certain properties. Also disable two `@test_broken` tests for now, because (a) the underlying issue is fixed in a Singular PR, but this causes OscarCI failures there.. (b) even if the underlying issue is fixed, those test were wrong, because `exterior_algebra` doesn't return a boolean, but the return value was used in a context where it must be boolean (namely as "argument" for `@test_broken`).
fingolfin
added
the
backport 1.0.x
hannes14
requested changes
Feb 22, 2024
lgoettgens
reviewed
Feb 22, 2024
hannes14
approved these changes
Feb 23, 2024
benlorenz
pushed a commit
that referenced
this pull request
Feb 23, 2024
Do not just verify that certain `exterior_algebra` invocations don't error out; also check that the returned values satisfy certain properties. Also disable two `@test_broken` tests for now, because (a) the underlying issue is fixed in a Singular PR, but this causes OscarCI failures there.. (b) even if the underlying issue is fixed, those test were wrong, because `exterior_algebra` doesn't return a boolean, but the return value was used in a context where it must be boolean (namely as "argument" for `@test_broken`).
benlorenz
removed
the
backport 1.0.x
benlorenz
added a commit
that referenced
this pull request
Feb 23, 2024
### Backported PRs - [x] #3367 - [x] #3379 - [x] #3369 - [x] #3291 - [x] #3325 - [x] #3350 - [x] #3351 - [x] #3365 - [x] #3366 - [x] #3382 - [x] #3373 - [x] #3341 - [x] #3346 - [x] #3381 - [x] #3385 - [x] #3387 - [x] #3398 - [x] #3399 - [x] #3374 - [x] #3406 - [x] #2823 - [x] #3298 - [x] #3386 - [x] #3412 - [x] #3392 - [x] #3415 - [x] #3394 - [x] #3391
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not just verify that certain
exterior_algebrainvocations don't error out; also check that the returned values satisfy certain properties.Also disable two
@test_brokentests for now, because (a) the underlying issue is fixed in a Singular PR, but this causes OscarCI failures there.. (b) even if the underlying issue is fixed, those test were wrong, becauseexterior_algebradoesn't return a boolean, but the return value was used in a context where it must be boolean (namely as "argument" for@test_broken).I hope we can quickly merge this, then we can re-run the oscar-system/Singular.jl#773 CI tests. If those pass, we'd merge that into Singular.jl, release Singular.jl -- then finally we could enable the two currently commented out (former
@test_broken) tests.CC @hannes14